From owner-cvs-all@FreeBSD.ORG Mon May 8 20:17:27 2006 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B655F16A407; Mon, 8 May 2006 20:17:27 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.FreeBSD.org (Postfix) with ESMTP id 747C743D49; Mon, 8 May 2006 20:17:26 +0000 (GMT) (envelope-from scottl@samsco.org) Received: from [10.10.3.185] ([69.15.205.254]) (authenticated bits=0) by pooker.samsco.org (8.13.4/8.13.4) with ESMTP id k48KHLAR086050; Mon, 8 May 2006 14:17:23 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <445FA74A.5040309@samsco.org> Date: Mon, 08 May 2006 14:17:14 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.7.12) Gecko/20060206 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Sam Leffler References: <200605082011.k48KB99P022584@repoman.freebsd.org> In-Reply-To: <200605082011.k48KB99P022584@repoman.freebsd.org> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=0.0 required=3.8 tests=none autolearn=failed version=3.1.1 X-Spam-Checker-Version: SpamAssassin 3.1.1 (2006-03-10) on pooker.samsco.org Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/ath if_ath.c if_ath_pci.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 08 May 2006 20:17:28 -0000 Sam Leffler wrote: > sam 2006-05-08 20:11:09 UTC > > FreeBSD src repository > > Modified files: > sys/dev/ath if_ath.c if_ath_pci.c > Log: > quiet tindexbox complaints about passing BUS_SPACE_MAXADDR as > a bus_size_t to bus_dma_tag_create; when PAE is enabled this > does not work > > Cluebat by: scottl > MFC after: 2 weeks > > Revision Changes Path > 1.144 +1 -1 src/sys/dev/ath/if_ath.c > 1.13 +1 -1 src/sys/dev/ath/if_ath_pci.c In general, maxsegsize should always be less than or equal to maxsize, and both should be expressed as a bus_size_t quantity. I'll check to make sure that this is documented appropriately. We still have a bit of a disconnect with mixing bus_space definitions with bus_dma. Warner and I have talked about this in the past, and we should probably Do Something About It before too long so that it's consistent and clear. Scott