From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Aug 26 11:00:25 2003 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 86B8C16A4BF for ; Tue, 26 Aug 2003 11:00:25 -0700 (PDT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id CB20E43FF9 for ; Tue, 26 Aug 2003 11:00:23 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id h7QI0NUp031195 for ; Tue, 26 Aug 2003 11:00:23 -0700 (PDT) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id h7QI0N2S031194; Tue, 26 Aug 2003 11:00:23 -0700 (PDT) Resent-Date: Tue, 26 Aug 2003 11:00:23 -0700 (PDT) Resent-Message-Id: <200308261800.h7QI0N2S031194@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Vivek Khera Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7625E16A4BF for ; Tue, 26 Aug 2003 10:59:52 -0700 (PDT) Received: from lorax.kciLink.com (lorax.kciLink.com [206.112.95.1]) by mx1.FreeBSD.org (Postfix) with ESMTP id 8143643FE3 for ; Tue, 26 Aug 2003 10:59:51 -0700 (PDT) (envelope-from vivek@lorax.kciLink.com) Received: from localhost (localhost [127.0.0.1]) by lorax.kciLink.com (Postfix) with ESMTP id C16083E43 for ; Tue, 26 Aug 2003 13:59:49 -0400 (EDT) Received: from lorax.kciLink.com ([127.0.0.1]) by localhost (lorax.kciLink.com [127.0.0.1]) (amavisd-new, port 10024) with SMTP id 56083-09 for ; Tue, 26 Aug 2003 13:59:39 -0400 (EDT) Received: by lorax.kciLink.com (Postfix, from userid 120) id 663013E41; Tue, 26 Aug 2003 13:59:39 -0400 (EDT) Message-Id: <20030826175939.663013E41@lorax.kciLink.com> Date: Tue, 26 Aug 2003 13:59:39 -0400 (EDT) From: Vivek Khera To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/56011: bonnie++ doesn't do large files X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Vivek Khera List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Aug 2003 18:00:25 -0000 >Number: 56011 >Category: ports >Synopsis: bonnie++ doesn't do large files >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Aug 26 11:00:23 PDT 2003 >Closed-Date: >Last-Modified: >Originator: Vivek Khera >Release: FreeBSD 4.7-RELEASE-p6 i386 >Organization: >Environment: System: FreeBSD lorax.kciLink.com 4.7-RELEASE-p6 FreeBSD 4.7-RELEASE-p6 #10: Mon Feb 24 13:13:48 EST 2003 vivek@lorax.kciLink.com:/u/lorax1/usr/obj/u/lorax1/usr/src/sys/LORAX i386 >Description: the bonnie++ benchmark can do large files if you tell it to. unfortunately, the configure script assumes you have the linux variety of large files (ie, using off64_t and friends). the patch (hack) enclosed bypasses the tests where it tries to warn you for using files which are 'too large'. >How-To-Repeat: >Fix: all other references to _LARGEFILE64_SOURCE should be left as-is since we don't need to alter the off_t type nor change the seek() calls. --- #bonnie++.cpp~ Mon Aug 25 17:08:46 2003 +++ bonnie++.cpp Mon Aug 25 17:08:46 2003 @@ -322,11 +322,7 @@ { char *sbuf = _strdup(optarg); char *size = strtok(sbuf, ":"); -#ifdef _LARGEFILE64_SOURCE file_size = size_from_str(size, "gt"); -#else - file_size = size_from_str(size, "g"); -#endif size = strtok(NULL, ""); if(size) { @@ -411,15 +407,6 @@ if(file_size % 1024 > 512) file_size = file_size + 1024 - (file_size % 1024); } -#ifndef _LARGEFILE64_SOURCE - if(file_size == 2048) - file_size = 2047; - if(file_size > 2048) - { - fprintf(stderr, "Large File Support not present, can't do %dM.\n", file_size); - usage(); - } -#endif globals.byte_io_size = __min(file_size, globals.byte_io_size); globals.byte_io_size = __max(0, globals.byte_io_size); @@ -503,14 +490,6 @@ && (directory_max_size < directory_min_size || directory_max_size < 0 || directory_min_size < 0) ) usage(); -#ifndef _LARGEFILE64_SOURCE - if(file_size > (1 << (31 - 20 + globals.io_chunk_bits)) ) - { - fprintf(stderr - , "The small chunk size and large IO size make this test impossible in 32bit.\n"); - usage(); - } -#endif if(file_size && globals.ram && (file_size * concurrency) < (globals.ram * 2) ) { fprintf(stderr >Release-Note: >Audit-Trail: >Unformatted: