From owner-freebsd-ipfw@FreeBSD.ORG  Wed Aug  3 04:30:17 2011
Return-Path: <owner-freebsd-ipfw@FreeBSD.ORG>
Delivered-To: freebsd-ipfw@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 23EAA1065670
	for <freebsd-ipfw@hub.freebsd.org>;
	Wed,  3 Aug 2011 04:30:17 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 13D748FC08
	for <freebsd-ipfw@hub.freebsd.org>;
	Wed,  3 Aug 2011 04:30:17 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p734UG8i046728
	for <freebsd-ipfw@freefall.freebsd.org>; Wed, 3 Aug 2011 04:30:16 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p734UG39046723;
	Wed, 3 Aug 2011 04:30:16 GMT (envelope-from gnats)
Date: Wed, 3 Aug 2011 04:30:16 GMT
Message-Id: <201108030430.p734UG39046723@freefall.freebsd.org>
To: freebsd-ipfw@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/131817: commit references a PR
X-BeenThere: freebsd-ipfw@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: IPFW Technical Discussions <freebsd-ipfw.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ipfw>
List-Post: <mailto:freebsd-ipfw@freebsd.org>
List-Help: <mailto:freebsd-ipfw-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ipfw>,
	<mailto:freebsd-ipfw-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Aug 2011 04:30:17 -0000

The following reply was made to PR kern/131817; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/131817: commit references a PR
Date: Wed,  3 Aug 2011 04:28:06 +0000 (UTC)

 Author: ae
 Date: Wed Aug  3 04:27:47 2011
 New Revision: 224622
 URL: http://svn.freebsd.org/changeset/base/224622
 
 Log:
   MFC r223753:
     ARP code reuses mbuf from ARP request to make a reply, but it does not
     reset rcvif to NULL. Since rcvif is not NULL, ipfw(4) supposes that ARP
     replies were received on specified interface.
     Reset rcvif to NULL for ARP replies to fix this issue.
   
     PR:		kern/131817
 
 Modified:
   stable/8/sys/netinet/if_ether.c
 Directory Properties:
   stable/8/sys/   (props changed)
   stable/8/sys/amd64/include/xen/   (props changed)
   stable/8/sys/cddl/contrib/opensolaris/   (props changed)
   stable/8/sys/contrib/dev/acpica/   (props changed)
   stable/8/sys/contrib/pf/   (props changed)
 
 Modified: stable/8/sys/netinet/if_ether.c
 ==============================================================================
 --- stable/8/sys/netinet/if_ether.c	Wed Aug  3 03:52:15 2011	(r224621)
 +++ stable/8/sys/netinet/if_ether.c	Wed Aug  3 04:27:47 2011	(r224622)
 @@ -843,6 +843,7 @@ reply:
  	ah->ar_pro = htons(ETHERTYPE_IP); /* let's be sure! */
  	m->m_len = sizeof(*ah) + (2 * ah->ar_pln) + (2 * ah->ar_hln);   
  	m->m_pkthdr.len = m->m_len;   
 +	m->m_pkthdr.rcvif = NULL;
  	sa.sa_family = AF_ARP;
  	sa.sa_len = 2;
  	(*ifp->if_output)(ifp, m, &sa, NULL);
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"