Date: Tue, 19 Jul 2016 12:25:45 +0000 From: Glen Barber <gjb@FreeBSD.org> To: Randall Stewart <rrs@netflix.com> Cc: Gleb Smirnoff <glebius@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r302998 - head/sys/kern Message-ID: <20160719122545.GC65494@FreeBSD.org> In-Reply-To: <5E551FA8-C779-45AE-B038-D8B51B53EEAA@netflix.com> References: <201607180929.u6I9T9Uw063705@repo.freebsd.org> <64C1543A-3EDE-4852-88EA-5B0B78FCF016@netflix.com> <58868615-8255-4D8B-BD9E-8E19A734CB6C@netflix.com> <5E551FA8-C779-45AE-B038-D8B51B53EEAA@netflix.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--4ZLFUWh1odzi/v6L Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 19, 2016 at 01:43:16PM +0200, Randall Stewart wrote: > Gleb >=20 > Ok >=20 > I have now updated >=20 > https://reviews.freebsd.org/D7135 >=20 > You can take this or not=E2=80=A6 I really don=E2=80=99t care either way= =E2=80=A6 (you are welcome to > own the kern_timeout.c code I hate it) :-) >=20 > Basically when you went off and re-factored kern_timeout.c I had worked i= n parallel on fixing > the bugs you were seeing.. There were three distinct problems that I fixe= d=E2=80=A6 but then > you had refactored the stop() routine.. and I thought ok.. thats fine. I = had actually thought about > doing something similar to what you did and was too chicken to poke that = much at it.. it has > always had a nasty habit of biting back when you make a lot of changes :-D >=20 > I know my version has worked for quite some time in my testing so I broug= ht it back. > Complete with its 3 return codes (I only recently switched to your versio= n and thus > started having difficulties with leaks and crashes)=E2=80=A6. >=20 > You are welcome not to use this.. I know it works (it ran > on a number of machines at NF last night.. and we will of course continue= testing > it as we finish our dev testing for the upcoming OCA software release).. = For now > this is what will be going out into the OCA=E2=80=99s at least :-) >=20 I'm honestly done with this topic, and at the point now where I'm considering backing out all changes to callout(9) and related changes to the state they were at in stable/10. This changes the KBI, and if it needs to be done, it needs to happen now. We cannot wait for RC1 phase for this, and the amount of churn to get things into a working state with the current implementation far outweighs the benefit of the dangers. Glen --4ZLFUWh1odzi/v6L Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXjhxEAAoJEAMUWKVHj+KT5xIP/jg4d79vtnMxLGSMprTEJ5ex +zXlcL1hut+Ja8tdBOdR0XxwnMZJKG77a4nRpi1pd3F+tohHxbthUHPzpq4Bs6Os LUftWJL9Zrkc/oGP3AziPPYtQmutNgmeKKBM6O88UEqp/cb8jtm6nmF56E0HxyMI uXQ6cjm9x6eRcRt1J8ta9QkmReUWWtoDc34br7pphEB/6O2174uvYWqtTof/SCKL KT2V6R9fX98ThhL3OgqO6a9pF51uLMN3UpDqrluOOQxk4NuJTMfEC51WQtY+HGAL ZRDmUj+/fWgNVgk6sbdBgJPgH+W+EJtCgg15ietOofur+7kJBbT9NxvaIfHJhN3N TCADGLSZfCryX7/bUET8xkqXUOHRxxF3Ukp5oby6NRUwzE6H3hqk0/MJgLWHsVyI 1E46Ay2DN9+gLuhkIhx6rNF7a3xvA6ZmMIk6uPZoi1V7BAou9XS6cTZiR8xAqy9T 5O0fU8dBQ4oeWJuZp2i1Yjq/9KmQ+GavO4LCdzLKThzTmJAuCm2I1L7HpnNfaQIR 6J0nIuoGczy7vFXZ7ZfMKi34p1g8WqVETwbr9lOPc/GLOhY/px13G1UdOKFU5+bs mgpkcNy1A625hrBRkjDhueHgXIOWB2zc+Iq3KGzeMqO1uuUoH9I3BFtFJhjSUROZ ZvFeKzepJ0aTtJzS+jXR =gsnG -----END PGP SIGNATURE----- --4ZLFUWh1odzi/v6L--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160719122545.GC65494>