From owner-svn-src-all@freebsd.org Mon Apr 16 13:52:41 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 667F5F84F1B; Mon, 16 Apr 2018 13:52:41 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 118F78604F; Mon, 16 Apr 2018 13:52:41 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 0B2001E362; Mon, 16 Apr 2018 13:52:41 +0000 (UTC) (envelope-from imp@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id w3GDqe5M021967; Mon, 16 Apr 2018 13:52:40 GMT (envelope-from imp@FreeBSD.org) Received: (from imp@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id w3GDqeMC021966; Mon, 16 Apr 2018 13:52:40 GMT (envelope-from imp@FreeBSD.org) Message-Id: <201804161352.w3GDqeMC021966@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: imp set sender to imp@FreeBSD.org using -f From: Warner Losh Date: Mon, 16 Apr 2018 13:52:40 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r332564 - head/sys/i386/i386 X-SVN-Group: head X-SVN-Commit-Author: imp X-SVN-Commit-Paths: head/sys/i386/i386 X-SVN-Commit-Revision: 332564 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 13:52:41 -0000 Author: imp Date: Mon Apr 16 13:52:40 2018 New Revision: 332564 URL: https://svnweb.freebsd.org/changeset/base/332564 Log: Use bool instead of boolean_t here. No reason to use boolean_t. Also, stop passing FALSE to a bool parameter. Modified: head/sys/i386/i386/db_trace.c Modified: head/sys/i386/i386/db_trace.c ============================================================================== --- head/sys/i386/i386/db_trace.c Mon Apr 16 13:52:23 2018 (r332563) +++ head/sys/i386/i386/db_trace.c Mon Apr 16 13:52:40 2018 (r332564) @@ -216,7 +216,7 @@ db_numargs(fp) int inst; int args; - argp = (char *)db_get_value((int)&fp->f_retaddr, 4, FALSE); + argp = (char *)db_get_value((int)&fp->f_retaddr, 4, false); /* * XXX etext is wrong for LKMs. We should attempt to interpret * the instruction at the return address in all cases. This @@ -226,7 +226,7 @@ db_numargs(fp) args = -1; } else { retry: - inst = db_get_value((int)argp, 4, FALSE); + inst = db_get_value((int)argp, 4, false); if ((inst & 0xff) == 0x59) /* popl %ecx */ args = 1; else if ((inst & 0xffff) == 0xc483) /* addl $Ibs, %esp */ @@ -255,7 +255,7 @@ db_print_stack_entry(name, narg, argnp, argp, callpc, while (n) { if (argnp) db_printf("%s=", *argnp++); - db_printf("%r", db_get_value((int)argp, 4, FALSE)); + db_printf("%r", db_get_value((int)argp, 4, false)); argp++; if (--n != 0) db_printf(","); @@ -304,8 +304,8 @@ db_nextframe(struct i386_frame **fp, db_addr_t *ip, st c_db_sym_t sym; const char *name; - eip = db_get_value((int) &(*fp)->f_retaddr, 4, FALSE); - ebp = db_get_value((int) &(*fp)->f_frame, 4, FALSE); + eip = db_get_value((int) &(*fp)->f_retaddr, 4, false); + ebp = db_get_value((int) &(*fp)->f_frame, 4, false); /* * Figure out frame type. We look at the address just before @@ -435,7 +435,7 @@ db_backtrace(struct thread *td, struct trapframe *tf, db_expr_t offset; c_db_sym_t sym; int instr, narg; - boolean_t first; + bool first; if (db_segsize(tf) == 16) { db_printf( @@ -473,13 +473,13 @@ db_backtrace(struct thread *td, struct trapframe *tf, instr = (int)(kdb_frame + 1); else instr = (int)&kdb_frame->tf_esp; - pc = db_get_value(instr, 4, FALSE); + pc = db_get_value(instr, 4, false); } if (count == -1) count = 1024; - first = TRUE; + first = true; while (count-- && !db_pager_quit) { sym = db_search_symbol(pc, DB_STGY_ANY, &offset); db_symbol_values(sym, &name, NULL); @@ -497,7 +497,7 @@ db_backtrace(struct thread *td, struct trapframe *tf, */ actframe = frame; if (first) { - first = FALSE; + first = false; if (sym == C_DB_SYM_NULL && sp != 0) { /* * If a symbol couldn't be found, we've probably @@ -506,13 +506,13 @@ db_backtrace(struct thread *td, struct trapframe *tf, */ db_print_stack_entry(name, 0, 0, 0, pc, NULL); - pc = db_get_value(sp, 4, FALSE); + pc = db_get_value(sp, 4, false); if (db_search_symbol(pc, DB_STGY_PROC, &offset) == C_DB_SYM_NULL) break; continue; } else if (tf != NULL) { - instr = db_get_value(pc, 4, FALSE); + instr = db_get_value(pc, 4, false); if ((instr & 0xffffff) == 0x00e58955) { /* pushl %ebp; movl %esp, %ebp */ actframe = (void *)(get_esp(tf) - 4); @@ -554,7 +554,7 @@ db_backtrace(struct thread *td, struct trapframe *tf, if (actframe != frame) { /* `frame' belongs to caller. */ pc = (db_addr_t) - db_get_value((int)&actframe->f_retaddr, 4, FALSE); + db_get_value((int)&actframe->f_retaddr, 4, false); continue; } @@ -588,7 +588,7 @@ db_trace_self(void) __asm __volatile("movl %%ebp,%0" : "=r" (ebp)); frame = (struct i386_frame *)ebp; - callpc = (db_addr_t)db_get_value((int)&frame->f_retaddr, 4, FALSE); + callpc = (db_addr_t)db_get_value((int)&frame->f_retaddr, 4, false); frame = frame->f_frame; db_backtrace(curthread, NULL, frame, callpc, 0, -1); }