Date: Fri, 21 Dec 2012 16:03:47 +0100 From: Davide Italiano <davide@freebsd.org> To: attilio@freebsd.org Cc: svn-src-projects@freebsd.org, Adrian Chadd <adrian@freebsd.org>, src-committers@freebsd.org, Alexander Motin <mav@freebsd.org> Subject: Re: svn commit: r244533 - in projects/calloutng: share/man/man9 sys/dev/atkbdc sys/dev/random sys/dev/syscons sys/kern sys/sys Message-ID: <CACYV=-Fr7%2BXwHDqAO2nm4QikWEQOT=8CRs7ffM1eusiC_Era0g@mail.gmail.com> In-Reply-To: <CAJ-FndAGHs0dYKmRqXiHA8uR=obW9WVcdqq8zS1Yjbn9Xi3A3A@mail.gmail.com> References: <201212211108.qBLB8jwa047382@svn.freebsd.org> <CAJ-VmokHDoPwO57tgyU_quKjVzEZ1wgZd2w=RxXtgMxSEJRY8Q@mail.gmail.com> <CACYV=-FLsfP4nJaVYvY76Eda42jgCBJ8Qe3KeuERkGXYsfHd7g@mail.gmail.com> <CAJ-FndAGHs0dYKmRqXiHA8uR=obW9WVcdqq8zS1Yjbn9Xi3A3A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 21, 2012 at 4:02 PM, Attilio Rao <attilio@freebsd.org> wrote: > On Fri, Dec 21, 2012 at 3:59 PM, Davide Italiano <davide@freebsd.org> wrote: >> On Fri, Dec 21, 2012 at 3:50 PM, Adrian Chadd <adrian@freebsd.org> wrote: >>> Hi, >>> >>> There's a DELAY (bt.frac >> 44) there; please write or use a >>> BINTIME_TO_USEC macro instead? >>> >>> Since you're touching kqueue, do you guys have a testing plan for >>> verifying kqueue operation is still working right? >>> >> >> I do think web servers -- as well as tons of other applications use it. >> Other than that, the commit doesn't change kqueue() semantics. > > This test by gianni@ was very good at finding callout races in the past: > http://people.freebsd.org/~attilio/callout/test.c > > Attilio > > > -- > Peace can only be achieved by understanding - A. Einstein Thanks Attilio, I'm going to run it on my test machine today. Davide
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACYV=-Fr7%2BXwHDqAO2nm4QikWEQOT=8CRs7ffM1eusiC_Era0g>