From owner-svn-ports-head@freebsd.org  Mon Apr 24 21:37:33 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3EF5ED4EF37;
 Mon, 24 Apr 2017 21:37:33 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: from apnoea.adamw.org (apnoea.adamw.org [104.225.5.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "apnoea.adamw.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id D91AD1C6E;
 Mon, 24 Apr 2017 21:37:32 +0000 (UTC) (envelope-from adamw@adamw.org)
Received: by apnoea.adamw.org (OpenSMTPD) with ESMTPSA id 7fb7df21
 TLS version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO;
 Mon, 24 Apr 2017 15:37:30 -0600 (MDT)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: svn commit: r439345 - in head/sysutils/cdrdao: . files
From: Adam Weinberger <adamw@adamw.org>
In-Reply-To: <201704242023.v3OKNN8q058653@repo.freebsd.org>
Date: Mon, 24 Apr 2017 15:37:29 -0600
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <627E45C6-8463-4EC2-93F5-0246C4122059@adamw.org>
References: <201704242023.v3OKNN8q058653@repo.freebsd.org>
To: Marius Strobl <marius@FreeBSD.org>
X-Mailer: Apple Mail (2.3273)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 24 Apr 2017 21:37:33 -0000

> On 24 Apr, 2017, at 14:23, Marius Strobl <marius@FreeBSD.org> wrote:
>=20
> Author: marius
> Date: Mon Apr 24 20:23:23 2017
> New Revision: 439345
> URL: https://svnweb.freebsd.org/changeset/ports/439345
>=20
> Log:
>  - Move the inclusion of bsd.port.pre.mk up slightly so ${UNAME} is =
also
>    available in the gcdmaster slave port at the required point in time
>    (it's unclear why this was no problem with the cdrdao port before). =
[1]

Because you didn't add the !=3D until r439255. Using !=3D is almost =
always a bad thing in a port Makefile. Why aren't you using ${ARCH}?

# Adam


--=20
Adam Weinberger
adamw@adamw.org
https://www.adamw.org