From owner-p4-projects@FreeBSD.ORG  Fri Jan 19 08:51:32 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id EB51316A417; Fri, 19 Jan 2007 08:51:31 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id C695C16A40F;
	Fri, 19 Jan 2007 08:51:31 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 88CE613C471;
	Fri, 19 Jan 2007 08:51:31 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.13.4/8.13.4) with ESMTP id l0J8p1w6006209;
	Fri, 19 Jan 2007 01:51:02 -0700 (MST) (envelope-from imp@bsdimp.com)
Date: Fri, 19 Jan 2007 01:51:22 -0700 (MST)
Message-Id: <20070119.015122.514366110.imp@bsdimp.com>
To: hselasky@freebsd.org
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <200701152255.l0FMtKId033379@repoman.freebsd.org>
References: <200701152255.l0FMtKId033379@repoman.freebsd.org>
X-Mailer: Mew version 4.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Fri, 19 Jan 2007 01:51:02 -0700 (MST)
Cc: perforce@freebsd.org
Subject: Re: PERFORCE change 112957 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 19 Jan 2007 08:51:32 -0000

In message: <200701152255.l0FMtKId033379@repoman.freebsd.org>
            Hans Petter Selasky <hselasky@freebsd.org> writes:
: ==== //depot/projects/usb/src/sys/dev/pccbb/pccbb.c#3 (text+ko) ====
: 
: @@ -302,10 +302,11 @@
:  	 * for the kldload/unload case to work.  If we failed to do that, then
:  	 * we'd get duplicate devices when cbb.ko was reloaded.
:  	 */
: -	device_get_children(brdev, &devlist, &numdevs);
: -	for (tmp = 0; tmp < numdevs; tmp++)
: -		device_delete_child(brdev, devlist[tmp]);
: -	free(devlist, M_TEMP);
: +	if (!device_get_children(brdev, &devlist, &numdevs)) {
: +		for (tmp = 0; tmp < numdevs; tmp++)

Actually this is a problem.  While the old code ignores errors, I
don't think that's really the right thing to do here.  It is critical
that the children be deleted.

Warner