From owner-svn-src-head@freebsd.org Tue Jun 5 02:56:23 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8298AFE45C4 for ; Tue, 5 Jun 2018 02:56:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x231.google.com (mail-io0-x231.google.com [IPv6:2607:f8b0:4001:c06::231]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 09E1C79231 for ; Tue, 5 Jun 2018 02:56:23 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x231.google.com with SMTP id t6-v6so1470626iob.10 for ; Mon, 04 Jun 2018 19:56:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=W3wufb5Ursl3aQy899paiAoVgNBEcIhZNtUhilAZDws=; b=DcH7EN0AUNEFa7/k++EOSwr4sRrDzKGaXv5csN1583SANk/BV/zXbBST5JgP6WEtQN dDvh0SVE/YSA2t5UYOoVj8kkjQk8OSQHN8RAUOAtn6f4KD79MVmCT6yJxuO4YJZyegDq mPQNm4788jHU+YODI6FUDmA0WwRfMJbtLR2pzdmBC+Y/yQLWkPqZLgedwQkwS3wkNNOe kuQMkT4fHAQ4fRBx5nQmZ6YKSb0WJdVK9GV7XHngO4oywln+ja/nMoCTX4FYSImmpN50 Ks3aboO/8+9aFK+mQVjS9CKAQqz29gcMAhIZX+Dm30iYDhZax2KvMymlVo6j8Ob/aT2d NZHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W3wufb5Ursl3aQy899paiAoVgNBEcIhZNtUhilAZDws=; b=lOa0gWBzlkERgvP617QUNNgMS5LdGzRLYpngi7Y7CBxVov2XlNtvXw57P7XLJvu+E9 O6U0oSLqt3jutg6ObD8CKiK21L3JvB95Lqq2yUaBUSVSK3ZAK/vLTtjBcvtOhqgqFNj4 p5qBB3PxgwlB98VnCKJU3TccpfDOROQVp2vRSocIdGEJCLhYw9/p3htgVnnOKt0TRyXN /UgWFr4yC/iLezRWK+GMxXMqP1FO+D8pKPblNZnCJ1BG4PzKtDLlmmnYtkYSYn3UbzfS uyJZyhLpDBMD1f85cpV84RssRAnbU7xVxQDyteCHrjIlDbI0SCG3vwe5O/r1NVElRnjM r/Pw== X-Gm-Message-State: ALKqPweG+2UUZSPTv4aIFrde6di+Wy9/YUbGXaXob35RrNBi0P07lPqb H+aQY+scINtPBOzQq1KL6IcAGZCIiI+ucseM8IXSWw== X-Google-Smtp-Source: ADUXVKLyLOAYpFPpo2YBQ/ux1P6Ge3s99bij3clgqxv6BgwNupdt6ITSAbijEZ8I277moCSIsCKxBSoVghIwbPeKQbA= X-Received: by 2002:a6b:be01:: with SMTP id o1-v6mr23131541iof.299.1528167382201; Mon, 04 Jun 2018 19:56:22 -0700 (PDT) MIME-Version: 1.0 References: <1528164479.32688.223.camel@freebsd.org> <201806050247.w552lcRx098576@pdx.rh.CN85.dnsmgr.net> In-Reply-To: <201806050247.w552lcRx098576@pdx.rh.CN85.dnsmgr.net> From: Warner Losh Date: Mon, 4 Jun 2018 20:56:10 -0600 Message-ID: Subject: Re: svn commit: r334630 - head/usr.bin/indent To: "Rodney W. Grimes" Cc: Ian Lepore , "Piotr P. Stefaniak" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.26 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 02:56:23 -0000 On Mon, Jun 4, 2018, 8:47 PM Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > [ Charset ISO-8859-1 unsupported, converting... ] > > On Mon, 2018-06-04 at 17:00 -0700, Rodney W. Grimes wrote: > > > > > > > > Author: pstef > > > > Date: Mon Jun??4 20:24:31 2018 > > > > New Revision: 334630 > > > > URL: https://svnweb.freebsd.org/changeset/base/334630 > > > > > > > > Log: > > > > ? indent(1): remove static const char copyright[] > > > > ?? > > > > ? It repeats what is already said in the heading comment and it's > optimized out > > > > ? so serves no purpose. > > > The purpose would be to put a copyright into the binary, and why that > is not > > > happening when the original authors intended that is not good. > > > > > > This is a regression, as 5.4p8 shows: > > > {108}% strings /usr/bin/indent | grep -i copy > > > bcopy > > > @(#) Copyright (c) 1985 Sun Microsystems, Inc. > > > @(#) Copyright (c) 1976 Board of Trustees of the University of > Illinois. > > > @(#) Copyright (c) 1980, 1993 > > > > > > Please walk very very very carefully around all things "copyright". > > > > > > > Does it matter what the original author intended? > Yes, it does. > > > Nothing in the > > license text itself requires that copyright info be included in the > > binary (it just has to be in the docs and accompanying materials). So > > why would an edit to remove that from the binary be any different than > > any other edit to the code that any committer chooses to make? > > Because he deleted lines that contain the word "copyright" > and that is just a dangerious place to play. > It looked fine to me. All the dates predate the adoption of the Berne Convention. Marking isn't needed anymore for a copyright. The same text is earlier in the file. I'm not sure there is a problem here... Warner Warner >