Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Jul 1996 17:26:00 +0200
From:      andreas@marvin.RoBIN.de
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   bin/1386: lpf Text Filter does not work with iso 8859-1 Characters
Message-ID:  <199607131526.RAA00388@marvin.RoBIN.de>
Resent-Message-ID: <199607160220.TAA16844@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         1386
>Category:       bin
>Synopsis:       lpf Text Filter does not work with iso 8859-1 Characters
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Jul 15 19:20:01 PDT 1996
>Last-Modified:
>Originator:     Andreas Lohr
>Organization:
At home
>Release:        FreeBSD 2.1-STABLE i386
>Environment:

	I want to use the lpf to print iso 8859-1 chars on my HP Deskjet.

>Description:

	The Text Filter /usr/libexec/lpr/lpf does not handle
	ISO 8859-1 Characters correctly. Better, it does not
	handle any chars with an ascii value greater than 127.

>How-To-Repeat:

	Print some text with chars > 127.

>Fix:

	The fix is very easy. The variable 'ch' in the source file
	/usr/src/usr.sbin/lpr/filters/lpf.c has to declared as an
	int instead of a char. 

*** lpf.c.dist  Sat Jul 13 15:29:26 1996
--- lpf.c       Sat Jul 13 15:29:49 1996
***************
*** 79,85 ****
        register int i, col;
        register char *cp;
        int done, linedone, maxrep;
!       char ch, *limit;
  
        while (--argc) {
                if (*(cp = *++argv) == '-') {
--- 79,86 ----
        register int i, col;
        register char *cp;
        int done, linedone, maxrep;
!       char *limit;
!       int ch;
  
        while (--argc) {
                if (*(cp = *++argv) == '-') {


>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199607131526.RAA00388>