From owner-freebsd-current@FreeBSD.ORG Mon Jul 28 03:42:34 2008 Return-Path: Delivered-To: freebsd-current@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CD1AB1065673 for ; Mon, 28 Jul 2008 03:42:34 +0000 (UTC) (envelope-from mcdouga9@egr.msu.edu) Received: from mx.egr.msu.edu (surfnturf.egr.msu.edu [35.9.37.164]) by mx1.freebsd.org (Postfix) with ESMTP id 9474A8FC17 for ; Mon, 28 Jul 2008 03:42:34 +0000 (UTC) (envelope-from mcdouga9@egr.msu.edu) Received: from localhost (localhost [127.0.0.1]) by mx.egr.msu.edu (Postfix) with ESMTP id 1DDCC71F17B; Sun, 27 Jul 2008 23:24:28 -0400 (EDT) X-Virus-Scanned: amavisd-new at egr.msu.edu Received: from mx.egr.msu.edu ([127.0.0.1]) by localhost (surfnturf.egr.msu.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jtk8DubXoN+j; Sun, 27 Jul 2008 23:24:27 -0400 (EDT) Received: from localhost (daemon.egr.msu.edu [35.9.44.65]) by mx.egr.msu.edu (Postfix) with ESMTP id EF8D971F179; Sun, 27 Jul 2008 23:24:27 -0400 (EDT) Received: by localhost (Postfix, from userid 21281) id DC5A6704; Sun, 27 Jul 2008 23:24:27 -0400 (EDT) Date: Sun, 27 Jul 2008 23:24:27 -0400 From: Adam McDougall To: Pawel Jakub Dawidek Message-ID: <20080728032427.GN79560@egr.msu.edu> References: <20080727125413.GG1345@garage.freebsd.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080727125413.GG1345@garage.freebsd.pl> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: freebsd-current@FreeBSD.org Subject: Re: ZFS patches. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Jul 2008 03:42:35 -0000 On Sun, Jul 27, 2008 at 02:54:13PM +0200, Pawel Jakub Dawidek wrote: Hi. http://people.freebsd.org/~pjd/patches/zfs_20080727.patch.bz2 The patch applied fine for me, but I get a compile error part way through a buildworld. My world/kernel is from -current from Thursday, I also tried csupping HEAD first, cleaning up my source tree, doing things with headers I shouldn't (which I will revert). To the best of my weak knowledge of C, it seems like ace_t should be fine (I tried to trace it through the includes). Am I doing something wrong? Also, is this patch expected to apply to 7? (I can find out for myself if I don't hear). Thanks. cc -O2 -pipe -I/usr/src/cddl/lib/libzpool/../../../sys/cddl/compat/opensolaris -I/usr/src/cddl/lib/libzpool/../../../cddl/compat/opensolaris/include -I/usr/src/cddl/lib/libzpool/../../../cddl/compat/opensolaris/lib/libumem -I/usr/src/cddl/lib/libzpool/../../../cddl/contrib/opensolaris/lib/libzpool/common -I/usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/sys -I/usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs -I/usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/common/zfs -I/usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common -I/usr/src/cddl/lib/libzpool/../../../cddl/contrib/opensolaris/head -I/usr/src/cddl/lib/libzpool/../../../cddl/lib/libumem -I/usr/src/cddl/lib/libzpool/../../../cddl/contrib/opensolaris/lib/libnvpair -DWANTS_MUTEX_OWNED -I/usr/src/cddl/lib/libzpool/../../../lib/libpthread/thread -I/usr/src/cddl/lib/libzpool/../../../lib/libpthread/sys -I/usr/src/cddl/lib/libzpool/../../../lib/libthr/arch/amd64/include -fstack-protector -Wno-unknown-pragmas -c /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c:35: error: expected ')' before '*' token /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c: In function 'zfs_oldacl_byteswap': /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c:127: error: 'ace_t' undeclared (first use in this function) /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c:127: error: (Each undeclared identifier is reported only once /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c:127: error: for each function it appears in.) /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c:129: error: expected expression before ')' token /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c: In function 'zfs_znode_byteswap': /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c:177: error: 'ace_t' undeclared (first use in this function) /usr/src/cddl/lib/libzpool/../../../sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zfs_byteswap.c:177: error: expected expression before ')' token *** Error code 1 Stop in /usr/src/cddl/lib/libzpool. *** Error code 1 Stop in /usr/src/cddl/lib. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src. *** Error code 1 Stop in /usr/src.