From owner-freebsd-multimedia@FreeBSD.ORG  Thu Jun 19 12:03:58 2008
Return-Path: <owner-freebsd-multimedia@FreeBSD.ORG>
Delivered-To: freebsd-multimedia@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id EAB43106566C
	for <freebsd-multimedia@FreeBSD.org>;
	Thu, 19 Jun 2008 12:03:58 +0000 (UTC)
	(envelope-from ganael.laplanche@martymac.com)
Received: from data.galacsys.net (data.galacsys.net [217.24.81.1])
	by mx1.freebsd.org (Postfix) with ESMTP id AA2CD8FC12
	for <freebsd-multimedia@FreeBSD.org>;
	Thu, 19 Jun 2008 12:03:58 +0000 (UTC)
	(envelope-from ganael.laplanche@martymac.com)
Received: from martymac.com (webmail.galacsys.net [217.24.81.215])
	by data.galacsys.net (Postfix) with ESMTP id 8681E16A577;
	Thu, 19 Jun 2008 13:47:32 +0200 (CEST)
From: "Ganael LAPLANCHE" <ganael.laplanche@martymac.com>
To: bug-followup@FreeBSD.org, pav@FreeBSD.org, ganael.laplanche@martymac.com,
	freebsd-multimedia@FreeBSD.org, pav@FreeBSD.org
X-Openwebmail-Date: Thu, 19 Jun 2008 13:47:32 +0100
Message-Id: <20080619112038.M77482@martymac.com>
In-Reply-To: <200806191004.m5JA4575024903@freefall.freebsd.org>
References: <200806191004.m5JA4575024903@freefall.freebsd.org>
X-Mailer: Open WebMail 2.01 20030425
X-OriginatingIP: 157.99.64.43 (ganael.laplanche@martymac.com)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Date: Thu, 19 Jun 2008 13:47:32 +0200 (CEST)
Cc: 
Subject: Re: ports/123327: Port fix: graphics/libcaca - CONFIGURE_ENV
	incorrectly set
X-BeenThere: freebsd-multimedia@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Multimedia discussions <freebsd-multimedia.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-multimedia>
List-Post: <mailto:freebsd-multimedia@freebsd.org>
List-Help: <mailto:freebsd-multimedia-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-multimedia>, 
	<mailto:freebsd-multimedia-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 19 Jun 2008 12:03:59 -0000

On Thu, 19 Jun 2008 10:04:05 GMT, pav wrote

Hi Pav,

> Why is this patch needed? It builds without the patch, and manages to 
> link to ncursesw.

Without this patch, special LDFLAGS are simply overridden because appended a
second time to CONFIGURE_ENV by bsd.efl.mk :

# In bsd.efl.mk :
#[...]
#
# Initialize configure enviropment
#
CONFIGURE_ENV+= CPPFLAGS="-I${LOCALBASE}/include" \
                CFLAGS="-I${LOCALBASE}/include ${CFLAGS}" \
                LDFLAGS="-L${LOCALBASE}/lib ${LDFLAGS}"
#[...]

This leads to loosing '-lm -lncurses' in LDFLAGS. The solution is to set those
two flags in ${LDFLAGS} rather than directly in CONFIGURE_ENV.

make -V CONFIGURE_ENV shows this :

CPPFLAGS="-I/usr/local/include" LDFLAGS="-L/usr/local/lib -lm -lncurses" [...]
LDFLAGS="-L/usr/local/lib " [...]

(Note that there is the same problem with CPPFLAGS and CFLAGS.)

You can reproduce this bug by building vlock with CACASAVER option set to ON and
try to launch 'vlock -n -t 5 caca' after having added your account to group
vlock:*:129:. It fails to load the screen saver, unless this patch is used...

Best regards,

Ganaël LAPLANCHE
ganael.laplanche@martymac.com
http://www.martymac.com