From owner-svn-src-all@freebsd.org Tue Jul 19 13:46:58 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 668B3B9E53B for ; Tue, 19 Jul 2016 13:46:58 +0000 (UTC) (envelope-from rrs@netflix.com) Received: from mail-wm0-x236.google.com (mail-wm0-x236.google.com [IPv6:2a00:1450:400c:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id EEC6D1E55 for ; Tue, 19 Jul 2016 13:46:57 +0000 (UTC) (envelope-from rrs@netflix.com) Received: by mail-wm0-x236.google.com with SMTP id o80so27177874wme.1 for ; Tue, 19 Jul 2016 06:46:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netflix.com; s=google; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=cbkwfU1SQm13mj4CPVN3YAH8Sg6ACWOtoDazr/y2M8I=; b=kPCDZ+KnV/+7VAgj2iN8TULuB9Z31/ChTKbqGDRWjor+cPY/T7vrOpJ1Y4SsbJIlT5 Flw12v6TD9De4odUa2zD7Mdgqu2M/MHdGY7hF3M8Y/HM9c6xIitEh98pcR5EPt70Y7Nf I5rm3koaJTFnmqJHBDk7MaxPtAVZ2BJa30JFo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=cbkwfU1SQm13mj4CPVN3YAH8Sg6ACWOtoDazr/y2M8I=; b=cGZSedxzbXK89eOLb4vbuai8UjSZ1eH4PhEJ5BibEBtVeIwpPLLxYY+uCkwXhrasse a3DoNovIlvz+Th2quHpCZz/xq6yjPfzIR1FddhxbgJkTDYWUiIju6XCfZfRxWGebJ5fW QnETuD+dKEKYePPUffl/EWi3eT/CM21vcJkMToKH3uq2+BYC/E8JoEl2PW3N07ea6AVt FnGTEzLp7MBnQ10OKCLmWWo+9e/ziItzDjWZQXeSNYJ06ek6ZyW2sBXRUsI0OycXUdXB 9u5G8/BASEfXH2to3tcQtKESbzrUDxmLWZwMgBt1fIAeWIXDb/8xmZ/40T1E6fBr4lw0 wqwA== X-Gm-Message-State: ALyK8tKWvBwD+fs2RzQPFiUGdvF4azZM9VduFgn+ZEjq7RcMaOpcdpmA35tA7/QXObB3wUYB X-Received: by 10.28.94.18 with SMTP id s18mr4336513wmb.44.1468936015920; Tue, 19 Jul 2016 06:46:55 -0700 (PDT) Received: from surfer-172-29-73-217-hotspot.internet-for-guests.com ([62.214.2.210]) by smtp.gmail.com with ESMTPSA id m201sm23061649wma.11.2016.07.19.06.46.54 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Jul 2016 06:46:55 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r302998 - head/sys/kern From: Randall Stewart In-Reply-To: <20160719122545.GC65494@FreeBSD.org> Date: Tue, 19 Jul 2016 15:46:54 +0200 Cc: Gleb Smirnoff , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <03E667D5-A4C9-47B9-A8DD-49ECD0E2B7EB@netflix.com> References: <201607180929.u6I9T9Uw063705@repo.freebsd.org> <64C1543A-3EDE-4852-88EA-5B0B78FCF016@netflix.com> <58868615-8255-4D8B-BD9E-8E19A734CB6C@netflix.com> <5E551FA8-C779-45AE-B038-D8B51B53EEAA@netflix.com> <20160719122545.GC65494@FreeBSD.org> To: Glen Barber X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jul 2016 13:46:58 -0000 Glen: My changes work.. I have them running in NF in at least 1/2 dozen = machines. I am more than willing to commit them.. they actually are not much = different than whats in stable 10.. though I don=E2=80=99t know if the async-drain was = MFC=E2=80=99d there.. it needs to be in for TCP.. or else you will have yet another mess in that respect (TCP depends on ASYNC-drain). I can commit what I have.. if you like.. or not.. I really don=E2=80=99t = care (I hate kern_timeout.c :-o) R > On Jul 19, 2016, at 2:25 PM, Glen Barber wrote: >=20 > On Tue, Jul 19, 2016 at 01:43:16PM +0200, Randall Stewart wrote: >> Gleb >>=20 >> Ok >>=20 >> I have now updated >>=20 >> https://reviews.freebsd.org/D7135 >>=20 >> You can take this or not=E2=80=A6 I really don=E2=80=99t care either = way=E2=80=A6 (you are welcome to >> own the kern_timeout.c code I hate it) :-) >>=20 >> Basically when you went off and re-factored kern_timeout.c I had = worked in parallel on fixing >> the bugs you were seeing.. There were three distinct problems that I = fixed=E2=80=A6 but then >> you had refactored the stop() routine.. and I thought ok.. thats = fine. I had actually thought about >> doing something similar to what you did and was too chicken to poke = that much at it.. it has >> always had a nasty habit of biting back when you make a lot of = changes :-D >>=20 >> I know my version has worked for quite some time in my testing so I = brought it back. >> Complete with its 3 return codes (I only recently switched to your = version and thus >> started having difficulties with leaks and crashes)=E2=80=A6. >>=20 >> You are welcome not to use this.. I know it works (it ran >> on a number of machines at NF last night.. and we will of course = continue testing >> it as we finish our dev testing for the upcoming OCA software = release).. For now >> this is what will be going out into the OCA=E2=80=99s at least :-) >>=20 >=20 > I'm honestly done with this topic, and at the point now where I'm > considering backing out all changes to callout(9) and related changes = to > the state they were at in stable/10. >=20 > This changes the KBI, and if it needs to be done, it needs to happen > now. We cannot wait for RC1 phase for this, and the amount of churn = to > get things into a working state with the current implementation far > outweighs the benefit of the dangers. >=20 > Glen >=20 -------- Randall Stewart rrs@netflix.com 803-317-4952