Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 13 May 2016 10:47:28 -0700
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Glen Barber <gjb@FreeBSD.org>, "O. Hartmann" <ohartman@zedat.fu-berlin.de>
Cc:        freebsd-current <freebsd-current@freebsd.org>
Subject:   Re: WARNING: [r299313] make installworld overwrites master.passwd and group!
Message-ID:  <10483308-3757-b9d7-9024-b9ed0bfb6420@FreeBSD.org>
In-Reply-To: <20160510054746.GZ47527@FreeBSD.org>
References:  <20160510071557.5705384d@freyja.zeit4.iv.bundesimmobilien.de> <20160510054746.GZ47527@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 5/9/16 10:47 PM, Glen Barber wrote:
> On Tue, May 10, 2016 at 07:15:57AM +0200, O. Hartmann wrote:
>> On a most recent buildworld with make installworld/installkernel I faced the
>> fact that all the entries in /etc/master.passwd and /etc/group were reset to
>> the initial/vanilla values. Luckily, I was able to fetch backups
>> from /var/backups.
>>
>> I do not know which essential config files additionally got altered or reset to
>> the initial values.
>>
>> This bug is present on all systems I maintain and I ran into this problem on
>> approx ten boxes this morning.
>>
>> What is up here?
>>
> 
> Confirmed.  This is my fault, misreading what I thought was a mismerge
> (r299292).
> 
> Reverting it now.  I apologize for the inconvenience this caused you,
> and appreciate the prompt report on the issue.  It is reverted in
> r299317.


I've made the same mistake before.

Here's a patch that should be right:
https://people.freebsd.org/~bdrewery/patches/Makefile.inc1-restage-reinstall.diff


-- 
Regards,
Bryan Drewery



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?10483308-3757-b9d7-9024-b9ed0bfb6420>