From owner-freebsd-ports@freebsd.org Fri Nov 8 05:18:14 2019 Return-Path: Delivered-To: freebsd-ports@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7498E1A76DB for ; Fri, 8 Nov 2019 05:18:14 +0000 (UTC) (envelope-from russ.haley@gmail.com) Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 478T7T4g3jz3PCf; Fri, 8 Nov 2019 05:18:13 +0000 (UTC) (envelope-from russ.haley@gmail.com) Received: by mail-io1-xd36.google.com with SMTP id j20so4735130ioo.11; Thu, 07 Nov 2019 21:18:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NniqE4lXBglNJDGQT0Cepnxk0ufiV3O75U62eHna7+Q=; b=Xg8UevOIPsKWnaz9jaaS3hA4FbR8bO8kk9pVc8+CaLqwMDLc0OLr79gajaBRrpsD+O fkbZ2ildcpHg5t5gzE5US4PjGkSa/u8+jfkmKRyb3lw8EcuKw5l0uPWn9+qvX0kF8JWm 4pQ3USVjLc8MvFz46P9rscRxdL8OWpHt+t6mwNQMJ9mHW52GReXoY4efvQj0o1v3/Q8W 6FpUk6uIQ2ZDFxZEmSn5M7mR1ngwL13J5I5cwls3tGt0UPNWH94VXU+WcG+loOtddqjR MrfXbYcpbo4CkvGemA2RarUBbkrw1FadBemzXYlaDYtmTH+3UQ7nedy/xwvbnynrkH7b 8vkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NniqE4lXBglNJDGQT0Cepnxk0ufiV3O75U62eHna7+Q=; b=jtAYjzPzVjNysrssCz6Y+bxsViX+ekDUHhr6yTJE1YL05cR1BBSUY9ym1yfmS4Jawf eApVbM9PAxPv76LvUH64zSJ8qof6zba1s5PSl3nTM60BUbXj1V525DCMVDr5PNECGd3q baQ1Q4aZH09B6SZOW6yvegUueTIqhCUkJ6wR+8QMFL7DKpdFJzDX0nWfzhyYN0JMmHNI sBDpfP4u5DytI10qwswLa8nfaPRYcwHtiHoVkleiAMHEtDS89mJ2lqNjBjuJ5URgBb8n 4o2l4L3ISZRlOKPsEsoLbCOgGsM0tfWfeGc6YxG302VZzDzi6PiC+GhfTLwjt25/2dbx 1T+w== X-Gm-Message-State: APjAAAVCHdKOldK8Dq3XpNejfuB2DSqPl05hl1iNimzF/njCp5nCROam /2acFoE0zr/3Pe18ISqw/9cMvSwvUk5pAt4A9WLz/w== X-Google-Smtp-Source: APXvYqw5FkN69U+t+zT11Ry850ef7oBgG5Vn4f07W+36+dPNk2pT4IsYtYq67WtddyePTenXb2gUTc0CvqvCOPfmK2g= X-Received: by 2002:a05:6638:3e9:: with SMTP id s9mr9184137jaq.7.1573190292234; Thu, 07 Nov 2019 21:18:12 -0800 (PST) MIME-Version: 1.0 References: <20191106085621.6ghgryrttdgb442z@ivaldir.net> In-Reply-To: <20191106085621.6ghgryrttdgb442z@ivaldir.net> From: Russell Haley Date: Thu, 7 Nov 2019 21:18:08 -0800 Message-ID: Subject: Re: Adding FLAVORS to lua-luarocks To: Baptiste Daroussin Cc: freebsd-ports@freebsd.org X-Rspamd-Queue-Id: 478T7T4g3jz3PCf X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=Xg8UevOI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of russhaley@gmail.com designates 2607:f8b0:4864:20::d36 as permitted sender) smtp.mailfrom=russhaley@gmail.com X-Spamd-Result: default: False [-2.00 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2607:f8b0:4000::/36]; FREEMAIL_FROM(0.00)[gmail.com]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_COUNT_TWO(0.00)[2]; URI_COUNT_ODD(1.00)[11]; IP_SCORE_FREEMAIL(0.00)[]; IP_SCORE(0.00)[ip: (-6.18), ipnet: 2607:f8b0::/32(-2.34), asn: 15169(-2.01), country: US(-0.05)]; DKIM_TRACE(0.00)[gmail.com:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[6.3.d.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; TAGGED_FROM(0.00)[]; RCVD_TLS_ALL(0.00)[]; DWL_DNSWL_NONE(0.00)[gmail.com.dwl.dnswl.org : 127.0.5.0] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Nov 2019 05:18:14 -0000 On Wed, Nov 6, 2019 at 12:56 AM Baptiste Daroussin wrote: > On Tue, Nov 05, 2019 at 09:43:48PM -0800, Russell Haley wrote: > > Hello, > > > > I have a review for updating the Lua package manager - LuaRocks - it to > the > > latest revision, 3.2.1. The new port file uses an update to lua.mk from > > Andrew Gierth for using FLAVORS to support all available versions of Lua. > > The reviews are here: (LuaRocks) https://reviews.freebsd.org/D17814 and > > here: (Lua.mk) https://reviews.freebsd.org/D16494 > > > > In the LuaRocks port, I've added the flavors as a selection of port > OPTIONS > > to build the correct version. Unfortunately, using the OPTIONS isn't > ideal > > because it will save the selected option for the next time the port is > run, > > but that's not the desired use case. I wanted the build to *always* > prompt > > for a Lua version so it can be used for multiple side by side Lua > > installations. > > > > Any suggestions, alternatives to OPTIONS or other constructive input > would > > be appreciated. > > > If the lua.mk ever get the support for flavors committed in, there is no > need to > add any option framework or whatever to allow the user to pickup a flavor. > > if someone $ants to only build for a given flavor he will have to just to > run: > make FLAVOR=lua52 > > if building from poudriere: > poudriere bulk devel/lua-rocks@lua52 > > Best regards, > Bapt > Thank you for clarifying. How would you recommend I notify potential users that they should use flavors? I will look to add it to the port description but that doesn't feel like enough. Cheers, Russ