From owner-freebsd-mips@freebsd.org Fri Oct 20 23:06:16 2017 Return-Path: Delivered-To: freebsd-mips@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D7C6BE42564 for ; Fri, 20 Oct 2017 23:06:16 +0000 (UTC) (envelope-from yamori813@yahoo.co.jp) Received: from nh602-vm14.bullet.mail.ssk.yahoo.co.jp (nh602-vm14.bullet.mail.ssk.yahoo.co.jp [182.22.90.39]) by mx1.freebsd.org (Postfix) with SMTP id 71D1869817 for ; Fri, 20 Oct 2017 23:06:16 +0000 (UTC) (envelope-from yamori813@yahoo.co.jp) Received: from [182.22.66.103] by nh602.bullet.mail.ssk.yahoo.co.jp with NNFMP; 20 Oct 2017 23:04:22 -0000 Received: from [182.22.91.133] by t601.bullet.mail.ssk.yahoo.co.jp with NNFMP; 20 Oct 2017 23:04:22 -0000 Received: from [127.0.0.1] by omp606.mail.ssk.yahoo.co.jp with NNFMP; 20 Oct 2017 23:04:22 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 600578.53194.bm@omp606.mail.ssk.yahoo.co.jp Received: (qmail 35711 invoked by uid 60001); 20 Oct 2017 23:04:22 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.jp; s=yj20110701; t=1508540662; bh=MKMy+BW6G3u+PhKvdILWOcD2PStfbJZr9zNxb7DC3j4=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:X-YMail-JAS:References:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=rUaGRzxVZG/Taf+Q3tGuZMfjWNUyt9pdWA7FV1dNbIH8q6s+/kbdrUJjzxS6RM+5sh3E+Tmnjz9DeFFFJRsXo2H6kBVsmFIlNupcYLhRMExMwWX+Bv2jfJ/u2vkO/3uneaW49lGHKHTfiOoit7Xrh6b1oVM0TKBYtWOS9EKHgz4= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=yj20110701; d=yahoo.co.jp; h=Message-ID:X-YMail-OSG:Received:X-Mailer:X-YMail-JAS:References:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=ZOtfVMs8tyKPHAHlBLEViXQpI3xdk5Qw5uNolr+cXGj4A2IQn764ELcqhd7XwsH0GRaPtiOPyXy/YpmVWwiuxXcHL0RVfRjICs8cmQgRuwr7kjnPOVxHtal52nVOari6qr5WqlYcZ0N9arutDL+kaTVFJX1CKsZfofgKCTxELTs=; Message-ID: <405153.18836.qm@web101719.mail.ssk.yahoo.co.jp> X-YMail-OSG: 0wofEQYVM1l0Koz9H9ayBzr378yc9Ij2uKLP4xB6VWrGD_Q_x_n72EppAQUEfXbxbdCB4eyczbJCz9wLnbdJcHm.qYH2aixPLCLPuMS7Nv2N4yqf_FEoXVQ8GpUYTcxl2z41kn40PWX7YvMv5E.BAIv8TcLNgyZoCpyZRueBEbAGi9fLTvnhc0KCkC8RFtTPUZxms2bzyv30MpNsXZu.z4FP05klVaEOjYUcsvcMQg0KgFZAIyuGQ8AfaPpw2pMNoKCzXSvtPXBnwmkeCOwLSpjaiQlCjJSveLoWAEhFc5v.wToWhMcvtbk_xve1V7mCGdVxVx_f0uA.EqbMpEuTS1NKZMOmaQXOiqGK4iTpTKZnWifuTf_Nj31OyXsAymfextU.LFBx2_hWu2kS2aQHE7FCjMd9te7vhgk8bcBQz7dx0AiTCvID3gIomijbjS36PZu6sXe7Y95NKV5LqLSU_48FN2SA9A8Xs7uac24ZANZbR09fLW3udYQatCgFpj4Cv9e10okOm8kKQSmlIQh5i631J4vUF7pt47n_yhta3lFfKmJLHOfZg5CFDgBRQPtjnOypNxpmAL.3bV5uaXOrfR7yLcvlZoB_pcq82WoMOF9tHw-- Received: from [61.23.25.155] by web101719.mail.ssk.yahoo.co.jp via HTTP; Sat, 21 Oct 2017 08:04:21 JST X-Mailer: YahooMailWebService/0.8.111_74 X-YMail-JAS: uUd.l9MVM1lU5WyyD..vdSDue7OnGA5_2BMUyuTHEvgk7.P9NwTUrCOmnawoIb87ODjxM3jyOTz8if18f098WoS610ru7AKnCeTsOBIZnwGCgFg_rRjZbXVLIDc3g.ZFu.ZM References: <641147.96869.qm@web101704.mail.ssk.yahoo.co.jp> <1508511627.1383.48.camel@freebsd.org> Date: Sat, 21 Oct 2017 08:04:21 +0900 (JST) From: Mori Hiroki Reply-To: Mori Hiroki Subject: Re: about iicdev_writeto() on ralink soc To: Ian Lepore Cc: "freebsd-mips@freebsd.org" In-Reply-To: <1508511627.1383.48.camel@freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Oct 2017 23:06:17 -0000 Hi=0A=0A=0A----- Original Message -----=0A> From: Ian Lepore =0A> To: Mori Hiroki =0A> Cc: "freebsd-mips@freeb= sd.org" =0A> Date: 2017/10/21, Sat 00:00=0A> Subj= ect: Re: about iicdev_writeto() on ralink soc=0A> =0A> On Fri, 2017-10-20 a= t 20:24 +0900, Mori Hiroki wrote:=0A>> Hi=0A>> =0A>> I make mips mediatek= iic driver. Mediatek(Ralink) soc(RT2880=A0and=A0=0A>> RT3050) is not supp= ort=A0nostop option at I2C device. This soc i2c=0A>> device is set transfe= r=A0length and automatically=A0send stop. And=0A>> Always send device addr= ess at first byte.=0A>> =0A>> your added=A0iicdev_writeto() not work in th= ese soc i2c device.=0A>> =0A>> =0A>> =0A>> https://svnweb.freebsd.org/base= ?view=3Drevision&revision=3D321583=0A>> =0A>> =0A>> Could you please chang= e single transfer in=A0iicdev_writeto() at=0A>> iiconf.c.=0A>> =0A>> Rega= rds=0A>> =0A>> Hiroki Mori=0A>=A0=0A=0AThanks check RT datasheet.=0A=0A> i= icdev_writeto() does the correct sequence of operations.=0A> =0A> I think i= f you set the ADDRDIS bit in the device control register and=0A> ignore the= NOSTOP flag in the messages, it will work for most slave=0A> devices. =A0S= ome slave devices require a repeat-start to work correctly,=0A> and those w= ill never work right on a controller like this.=0A> =0A> -- Ian=0A> =0A=0AN= o.=0A=0ARalink Datasheet is very confuse. ADDRDIR is register address disab= le.=0ADEVADDIS is device address disable.=A0=0A=0AIf not set=A0DEVADDIS and= =A0ADDRDIR then=0A=0A=A0=A0 ...=0A= =0AIf set ADDRDIR then=A0=0A=0A ...=0A=0AIf set DEVA= DDIS then ignore ADDRDIR=0A=0A ...=0A=0Aalways two= more byte send this soc.=0A=0ADriver review is this.=0A=0Ahttps://reviews.= freebsd.org/D12736=0A=0A=0AThanks=0A=0AHiroki Mori