Date: Thu, 25 Nov 2010 01:31:18 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Koop Mast <kwm@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/devel/glib20 Makefile ports/devel/glib20/files extra-arch-powerpc64 Message-ID: <20101125013118.GA39972@FreeBSD.org> In-Reply-To: <201011242106.oAOL6A3r006192@repoman.freebsd.org> References: <201011242106.oAOL6A3r006192@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Nov 24, 2010 at 09:06:10PM +0000, Koop Mast wrote:
> kwm 2010-11-24 21:06:10 UTC
>
> FreeBSD ports repository
>
> Modified files:
> devel/glib20 Makefile
> Added files:
> devel/glib20/files extra-arch-powerpc64
> Log:
> Due to a flaw in binutils 2.15, function names can conflict with
> ELF assembler directives on PPC64 systems. As a result, it is not possible
> to have functions named things like 'text' and 'data'.
> In glib-compile-schemas.c we have such a name.
Why was it made a conditional extra patch instead of correctly patching
it across the gang with corresponding comment? This is just one little
static function. Also, the patch should be submitted upstream (was it?).
Another thing is that ${.CURDIR}/files should probably be ${FILESDIR}
in this context.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101125013118.GA39972>