From owner-svn-src-head@freebsd.org Wed Nov 13 22:55:44 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3E4AF1BE969; Wed, 13 Nov 2019 22:55:44 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47D0ML5KWJz3Mhm; Wed, 13 Nov 2019 22:55:42 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 022063C0199; Wed, 13 Nov 2019 22:55:36 +0000 (UTC) Date: Wed, 13 Nov 2019 22:55:35 +0000 From: Brooks Davis To: Konstantin Belousov Cc: Brooks Davis , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r354694 - in head: lib/libc/gen sys/sys Message-ID: <20191113225535.GA17978@spindle.one-eyed-alien.net> References: <201911132151.xADLptvc074883@repo.freebsd.org> <20191113224640.GX2707@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="C7zPtVaVf+AK4Oqc" Content-Disposition: inline In-Reply-To: <20191113224640.GX2707@kib.kiev.ua> User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 47D0ML5KWJz3Mhm X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of brooks@spindle.one-eyed-alien.net has no SPF policy when checking 199.48.129.229) smtp.mailfrom=brooks@spindle.one-eyed-alien.net X-Spamd-Result: default: False [-6.51 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; IP_SCORE(-3.61)[ip: (-9.44), ipnet: 199.48.128.0/22(-4.71), asn: 36236(-3.85), country: US(-0.05)]; MIME_GOOD(-0.20)[multipart/signed,text/plain]; DMARC_NA(0.00)[freebsd.org]; AUTH_NA(1.00)[]; RCPT_COUNT_FIVE(0.00)[5]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; TO_MATCH_ENVRCPT_SOME(0.00)[]; R_SPF_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; FORGED_SENDER(0.30)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; SIGNED_PGP(-2.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; ASN(0.00)[asn:36236, ipnet:199.48.128.0/22, country:US]; FROM_NEQ_ENVFROM(0.00)[brooks@freebsd.org,brooks@spindle.one-eyed-alien.net]; RCVD_COUNT_ZERO(0.00)[0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Nov 2019 22:55:44 -0000 --C7zPtVaVf+AK4Oqc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Nov 14, 2019 at 12:46:40AM +0200, Konstantin Belousov wrote: > On Wed, Nov 13, 2019 at 09:51:55PM +0000, Brooks Davis wrote: > > Author: brooks > > Date: Wed Nov 13 21:51:55 2019 > > New Revision: 354694 > > URL: https://svnweb.freebsd.org/changeset/base/354694 > >=20 > > Log: > > elf_aux_info: Add support for AT_EXECPATH. > > =20 > > Reviewed by: emaste, sef > > MFC after: 3 days > > Sponsored by: DARPA, AFRL > > Differential Revision: https://reviews.freebsd.org/D22353 > >=20 > > Modified: > > head/lib/libc/gen/auxv.3 > > head/lib/libc/gen/auxv.c > > head/sys/sys/param.h > >=20 > > Modified: head/lib/libc/gen/auxv.3 > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/lib/libc/gen/auxv.3 Wed Nov 13 21:49:46 2019 (r354693) > > +++ head/lib/libc/gen/auxv.3 Wed Nov 13 21:51:55 2019 (r354694) > > @@ -24,7 +24,7 @@ > > .\" > > .\" $FreeBSD$ > > .\" > > -.Dd April 25, 2019 > > +.Dd November 13, 2019 > > .Dt ELF_AUX_INFO 3 > > .Os > > .Sh NAME > > @@ -48,6 +48,10 @@ can be requested: > > .Bl -tag -width AT_OSRELDATE > > .It AT_CANARY > > The canary value for SSP. > > +.It AT_EXECPATH > > +The path of executed program. > > +This will not be present if the process was initialized by > This is too strong statement. The auxv element might be not present > if vn_fullpath(9) failed, otherwise we do provide the path. >=20 > > +.Xr fexecve 2 . Would it be more accurate to change it from "will" to "may"? Referencing vn_fullpath(9) seems unhelpful in userspace programmer documentation. -- Brooks --C7zPtVaVf+AK4Oqc Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJdzInnAAoJEKzQXbSebgfAjVAH/jFv9jpaVtqOvHJc4+XDPeVJ 4dbHxff5z8VgSRgGqkSbVuRf4s3DySQWd5553941Toc/EqzYEZfwAZGSomwDk/Ct sr5Oybye2GyvwItruiztZNDikeJB71g8sRO8QRcRIt3R9B+HKgC8dTaR9EgZ9pfL LE1E87hCGQoSg/kIPLqBi+TCqDqFn1b96GWKjTOs+fyuU5E6QMv9O6ZMuqbOWYSV y7qS8HMjg4fRF5r/o2rlLnwXXd4buNVd8nvwudmnS1zfSNCMIXrtA2zh6i+cFpyz iDedn3rom9yNTwMtmUWd1qA2TBDvYNUKVWfcXoMD9Gv8cJrNYVzQgy+i4Q3/JMY= =Q4/Z -----END PGP SIGNATURE----- --C7zPtVaVf+AK4Oqc--