Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 10 Dec 2012 09:15:45 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Beech Rintoul <beech@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r308497 - head/editors/diakonos
Message-ID:  <20121210091545.GF34139@FreeBSD.org>
In-Reply-To: <201212082354.qB8NsjUr043541@svn.freebsd.org>
References:  <201212082354.qB8NsjUr043541@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Dec 08, 2012 at 11:54:44PM +0000, Beech Rintoul wrote:
> New Revision: 308497
> URL: http://svnweb.freebsd.org/changeset/ports/308497
> 
> @@ -1,15 +1,12 @@
> -# New ports collection makefile for:    diakonos
> -# Date created:         30 June 2009
> -# Whom:                 chris@officialunix.com
> -#
> +# Created by: Chris Petrik <chris@officialunix.com>
>  # $FreeBSD$
>  #

This is non-standard header.

> -MASTER_SITES=	http://diakonos.pist0s.ca/archives/
> -
> +MASTER_SITES=   http://diakonos.pist0s.ca/archives/ \

Wrong indentation.  Again, please be more careful with your use of
whitespace.  Modern editors often highlight whitespace characters, maybe you
will find this option useful.

> +         	http://distfiles.bsdjunk.com
>  MAINTAINER=	c.petrik.sosa@gmail.com
>  COMMENT=	A Linux editor for the masses

You could've dropped leading indefinite article from the COMMENT here.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20121210091545.GF34139>