Date: Wed, 12 Feb 2014 09:08:47 +0100 From: Benjamin Podszun <dar@darklajid.de> To: <freebsd-ports@freebsd.org> Subject: Re: dovecot, init script - is this expected or PR =?iso-8859-1?Q?worthy=3F?= Message-ID: <05e8cdca-8e86-4570-bbba-054433e401c8@darklajid.de> In-Reply-To: <CADfK3RXjyHdAGj_1zfoaAbAg0BKPRZ0k2Qsw2kRGbZnX7xGTAw@mail.gmail.com> References: <CAJOeo-1o%2BUDso9i6rtbAyTdpSCp8n3DhyVWq2ir5iNec3HoEFg@mail.gmail.com> <CADfK3RXjyHdAGj_1zfoaAbAg0BKPRZ0k2Qsw2kRGbZnX7xGTAw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wednesday, February 12, 2014 2:56:18 AM CEST, Stephen R Guglielmo wrote: > On Tue, Feb 11, 2014 at 12:24 PM, Benjamin Podszun < > benjamin.podszun@gmail.com> wrote: > >> service dovecot start >>=20 >> and .. that succeeds always, if dovecot_enable=3D"YES" is missing (which >> totally is an error on my part, obviously). >>=20 >> What I expect though is the typical "Can't do that, Dave. Try onestart >> perhaps" response - and some exit code that signals failure. >>=20 > > >> Is that a (tiny, minor) bug? Should I submit a PR for that? Or is that >> totally irrelevant and people out there would never fall for=20 >> that anyway..? >>=20 >> Thanks, >> Ben >>=20 > > Hey, > > I can't reproduce this on my system. I typically run the rc.d/ scripts > myself, but I did try using the `service` command as well. It works as > expected: The script returns no output when dovecot_enable is commented > out or set equal to NO in my /etc/rc.conf.local file, and it does not=20 start > or stop the dovecot processes. > > I'm using dovecot 1.2.17 on 10.0-RELEASE. Are you using dovecot 2? Hi. I .. think my mail was probably too convoluted and messy. My point? service foo start shouldn't be silent if the service isn't starting. The=20 default rc functions ensure that, give the 'Need foo_enable or onestart=20 instead' message. Dovecot's rc script doesn't, because it doesn't even=20 _invoke_ the rc functions if dovecot_enable !=3D YES. (dovecot2 for me, btw - but you described seeing exactly what I see:=20 Nothing, but the service isn't starting either) The whole point is that this silently fails. Is that okay? Regards, Ben
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?05e8cdca-8e86-4570-bbba-054433e401c8>