From owner-freebsd-current@FreeBSD.ORG Tue Apr 22 21:10:44 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8BF2437B401 for ; Tue, 22 Apr 2003 21:10:44 -0700 (PDT) Received: from magic.adaptec.com (magic-mail.adaptec.com [208.236.45.100]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0617743FBD for ; Tue, 22 Apr 2003 21:10:44 -0700 (PDT) (envelope-from scott_long@btc.adaptec.com) Received: from redfish.adaptec.com (redfish.adaptec.com [162.62.50.11]) by magic.adaptec.com (8.11.6/8.11.6) with ESMTP id h3N488Z10359; Tue, 22 Apr 2003 21:08:08 -0700 Received: from btc.btc.adaptec.com ([10.100.0.52]) by redfish.adaptec.com (8.8.8p2+Sun/8.8.8) with ESMTP id VAA28928; Tue, 22 Apr 2003 21:10:27 -0700 (PDT) Received: from btc.adaptec.com (hollin [10.100.253.56]) by btc.btc.adaptec.com (8.8.8+Sun/8.8.8) with ESMTP id WAA09983; Tue, 22 Apr 2003 22:10:19 -0600 (MDT) Message-ID: <3EA612F3.3060403@btc.adaptec.com> Date: Tue, 22 Apr 2003 22:13:39 -0600 From: Scott Long User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.2b) Gecko/20021125 X-Accept-Language: en-us, en MIME-Version: 1.0 To: David Leimbach References: <882B177C-753C-11D7-953D-0003937E39E0@mac.com> In-Reply-To: <882B177C-753C-11D7-953D-0003937E39E0@mac.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: freebsd-current@freebsd.org Subject: Re: Makefile in /usr/src/lib/libdisk WARNS change? PLEASE READ! X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Apr 2003 04:10:44 -0000 David Leimbach wrote: > > > > > > This just struck me as a possibility also about 20 seconds ago :) > > > > Here it is: [comments stripped] > > CPUTYPE?=athlon-mp > > CFLAGS= -pipe -msse -m3dnow > > MAKE_IDEA=YES > > > > I am now changing CFLAGS to simply "-pipe" to see what happens. > > > > And that had no affect it seems on the problem whatsoever. > Testing locally, it seems to be triggered by the lack of '-O' in the CFLAGS. FreeBSD has had a policy for quite some time of not supporting non-standard CFLAGS settings, though it's perfectly acceptable to debug and fix problems of this nature so long as the fix doesn't break the standard case. Your original patch looks fine to me. Poul-Henning seems to be one of the de-facto maintainers of libdisk right now. He was away on vacation last week and probably hasn't sorted through his Inbox all the way yet. If he doesn't respond soon, ping him or myself again. Scott