Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 4 Jun 2018 20:00:05 -0700 (PDT)
From:      "Rodney W. Grimes" <freebsd@pdx.rh.CN85.dnsmgr.net>
To:        Warner Losh <imp@bsdimp.com>
Cc:        "Rodney W. Grimes" <rgrimes@freebsd.org>, Ian Lepore <ian@freebsd.org>, "Piotr P. Stefaniak" <pstef@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r334630 - head/usr.bin/indent
Message-ID:  <201806050300.w55305GE098664@pdx.rh.CN85.dnsmgr.net>
In-Reply-To: <CANCZdfrxLcEMnapbJ-h07bRdDBkrUzm_OyMngK4_u1yMYoN+7Q@mail.gmail.com>

Next in thread | Previous in thread | Raw E-Mail | Index | Archive | Help
> On Mon, Jun 4, 2018, 8:47 PM Rodney W. Grimes <
> freebsd@pdx.rh.cn85.dnsmgr.net> wrote:
> 
> > [ Charset ISO-8859-1 unsupported, converting... ]
> > > On Mon, 2018-06-04 at 17:00 -0700, Rodney W. Grimes wrote:
> > > > >
> > > > > Author: pstef
> > > > > Date: Mon Jun??4 20:24:31 2018
> > > > > New Revision: 334630
> > > > > URL: https://svnweb.freebsd.org/changeset/base/334630
> > > > >
> > > > > Log:
> > > > > ? indent(1): remove static const char copyright[]
> > > > > ??
> > > > > ? It repeats what is already said in the heading comment and it's
> > optimized out
> > > > > ? so serves no purpose.
> > > > The purpose would be to put a copyright into the binary, and why that
> > is not
> > > > happening when the original authors intended that is not good.
> > > >
> > > > This is a regression, as 5.4p8 shows:
> > > > {108}% strings /usr/bin/indent | grep -i copy
> > > > bcopy
> > > > @(#) Copyright (c) 1985 Sun Microsystems, Inc.
> > > > @(#) Copyright (c) 1976 Board of Trustees of the University of
> > Illinois.
> > > > @(#) Copyright (c) 1980, 1993
> > > >
> > > > Please walk very very very carefully around all things "copyright".
> > > >
> > >
> > > Does it matter what the original author intended?
> > Yes, it does.
> >
> > > Nothing in the
> > > license text itself requires that copyright info be included in the
> > > binary (it just has to be in the docs and accompanying materials). So
> > > why would an edit to remove that from the binary be any different than
> > > any other edit to the code that any committer chooses to make?
> >
> > Because he deleted lines that contain the word "copyright"
> > and that is just a dangerious place to play.
> >
> 
> It looked fine to me. All the dates predate the adoption of the Berne
> Convention.

Which means exactly what?  That Berne does not apply, or does apply?

> Marking isn't needed anymore for a copyright.
Marking was needed at the time that copyright was applied, so that
marking should stay intact.

> The same text is
> earlier in the file. I'm not sure there is a problem here...

I dont make legal bets on "not sure", do you?

> Warner

-- 
Rod Grimes                                                 rgrimes@freebsd.org



Want to link to this message? Use this URL: <http://docs.FreeBSD.org/cgi/mid.cgi?201806050300.w55305GE098664>