From owner-svn-src-head@freebsd.org Tue Jun 5 03:00:08 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 606BDFE4E0E; Tue, 5 Jun 2018 03:00:08 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BA39B79510; Tue, 5 Jun 2018 03:00:07 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w55305BI098665; Mon, 4 Jun 2018 20:00:05 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w55305GE098664; Mon, 4 Jun 2018 20:00:05 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201806050300.w55305GE098664@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r334630 - head/usr.bin/indent In-Reply-To: To: Warner Losh Date: Mon, 4 Jun 2018 20:00:05 -0700 (PDT) CC: "Rodney W. Grimes" , Ian Lepore , "Piotr P. Stefaniak" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Jun 2018 03:00:08 -0000 > On Mon, Jun 4, 2018, 8:47 PM Rodney W. Grimes < > freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > > [ Charset ISO-8859-1 unsupported, converting... ] > > > On Mon, 2018-06-04 at 17:00 -0700, Rodney W. Grimes wrote: > > > > > > > > > > Author: pstef > > > > > Date: Mon Jun??4 20:24:31 2018 > > > > > New Revision: 334630 > > > > > URL: https://svnweb.freebsd.org/changeset/base/334630 > > > > > > > > > > Log: > > > > > ? indent(1): remove static const char copyright[] > > > > > ?? > > > > > ? It repeats what is already said in the heading comment and it's > > optimized out > > > > > ? so serves no purpose. > > > > The purpose would be to put a copyright into the binary, and why that > > is not > > > > happening when the original authors intended that is not good. > > > > > > > > This is a regression, as 5.4p8 shows: > > > > {108}% strings /usr/bin/indent | grep -i copy > > > > bcopy > > > > @(#) Copyright (c) 1985 Sun Microsystems, Inc. > > > > @(#) Copyright (c) 1976 Board of Trustees of the University of > > Illinois. > > > > @(#) Copyright (c) 1980, 1993 > > > > > > > > Please walk very very very carefully around all things "copyright". > > > > > > > > > > Does it matter what the original author intended? > > Yes, it does. > > > > > Nothing in the > > > license text itself requires that copyright info be included in the > > > binary (it just has to be in the docs and accompanying materials). So > > > why would an edit to remove that from the binary be any different than > > > any other edit to the code that any committer chooses to make? > > > > Because he deleted lines that contain the word "copyright" > > and that is just a dangerious place to play. > > > > It looked fine to me. All the dates predate the adoption of the Berne > Convention. Which means exactly what? That Berne does not apply, or does apply? > Marking isn't needed anymore for a copyright. Marking was needed at the time that copyright was applied, so that marking should stay intact. > The same text is > earlier in the file. I'm not sure there is a problem here... I dont make legal bets on "not sure", do you? > Warner -- Rod Grimes rgrimes@freebsd.org