Date: Mon, 11 Jun 2007 13:46:28 -0700 From: "Jack Vogel" <jfvogel@gmail.com> To: "Andre Oppermann" <andre@freebsd.org> Cc: Sam Leffler <sam@errno.com>, src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/net if.h Message-ID: <2a41acea0706111346l227b1399jd80d85771345d8be@mail.gmail.com> In-Reply-To: <466DB362.8010902@freebsd.org> References: <200706112008.l5BK8CQ7033543@repoman.freebsd.org> <466DACD6.4040606@errno.com> <2a41acea0706111330v6a39cf84o495f6acf62ba7ff7@mail.gmail.com> <2a41acea0706111333p5349993dg9315bfe8396f78a@mail.gmail.com> <466DB362.8010902@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 6/11/07, Andre Oppermann <andre@freebsd.org> wrote: > Jack Vogel wrote: > > On 6/11/07, Jack Vogel <jfvogel@gmail.com> wrote: > >> On 6/11/07, Sam Leffler <sam@errno.com> wrote: > >> > Andre Oppermann wrote: > >> > > andre 2007-06-11 20:08:12 UTC > >> > > > >> > > FreeBSD src repository > >> > > > >> > > Modified files: > >> > > sys/net if.h > >> > > Log: > >> > > Add IFCAP_LRO flag for drivers to announce their TCP Large > >> Receive Offload > >> > > capabilities. > >> > > > >> > > Revision Changes Path > >> > > 1.108 +1 -0 src/sys/net/if.h > >> > > http://cvsweb.FreeBSD.org/src/sys/net/if.h.diff?r1=1.107&r2=1.108 > >> > > > >> > > > >> > There are many offload capabilities defined that are not well thought > >> > out. In particular we do not distinguish between ipv4 and ipv6 for > >> > things like cksum and tso so there's no way to disable individual > >> > features. The ability to tweak LRO is clearly needed and clearly > >> belong > >> > as an ifnet capability but unilateraly deciding this is the wrong > >> approach. > >> > > >> > Sam > >> > >> We do distinguish between TSO4 and TSO6, its just that all the pieces > >> for 6 arent actually there yet, you are right about the cksum > >> granularity, > >> but I'm not convinced its needed. You might be right on the need to > >> fine tune the functionality, but having a big ON/OFF doesnt seem a > >> bad thing to me. > > > > Oh, one other useful tidbit, for Oplin when RSS is enabled you can't do > > CKSUM anyway, they reuse bits. > > What is Oplin? Our new 10G adapter, er, its code name, its really 82598.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2a41acea0706111346l227b1399jd80d85771345d8be>