From owner-cvs-all@FreeBSD.ORG  Mon Jun 11 20:46:29 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@freebsd.org
Delivered-To: cvs-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 752A016A46C
	for <cvs-all@freebsd.org>; Mon, 11 Jun 2007 20:46:29 +0000 (UTC)
	(envelope-from jfvogel@gmail.com)
Received: from wa-out-1112.google.com (wa-out-1112.google.com [209.85.146.183])
	by mx1.freebsd.org (Postfix) with ESMTP id 3DE7B13C468
	for <cvs-all@freebsd.org>; Mon, 11 Jun 2007 20:46:29 +0000 (UTC)
	(envelope-from jfvogel@gmail.com)
Received: by wa-out-1112.google.com with SMTP id j37so2477118waf
	for <cvs-all@freebsd.org>; Mon, 11 Jun 2007 13:46:28 -0700 (PDT)
DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta;
	h=domainkey-signature:received:received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=GeX4Nabx6Dm3RaVVpAfEhBxlZlI1i5C/U/pdcdHx0FgFcibKpV37cISlVW2g5qaORFBa26FSC2KCCH9vpv5V26FO36Icxj85W5298GO15A/SndaDEmlprBxlDpgMnU8xQASEGgcz5UUA5kA7+Y6qjL2NcaFsq1DsK6+oDubcOds=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta;
	h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references;
	b=Iqyx/MC5Rf+Q2DQnTk/vRyzwByoGMd3NMVamQjQbbG/Vp9mwFaUKMLroyiTjGZwBcj3clQCkJXrgi2LOZPeMqQ8nhbfI74j+Hhms7SPkxinr5I6GsZSa5f+mwdERDToCq+/oHXSPn5e++2/6Y6A85+kQQNTFY5bjRXDTSwqVJYs=
Received: by 10.115.74.1 with SMTP id b1mr5882530wal.1181594788833;
	Mon, 11 Jun 2007 13:46:28 -0700 (PDT)
Received: by 10.114.126.10 with HTTP; Mon, 11 Jun 2007 13:46:28 -0700 (PDT)
Message-ID: <2a41acea0706111346l227b1399jd80d85771345d8be@mail.gmail.com>
Date: Mon, 11 Jun 2007 13:46:28 -0700
From: "Jack Vogel" <jfvogel@gmail.com>
To: "Andre Oppermann" <andre@freebsd.org>
In-Reply-To: <466DB362.8010902@freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200706112008.l5BK8CQ7033543@repoman.freebsd.org>
	<466DACD6.4040606@errno.com>
	<2a41acea0706111330v6a39cf84o495f6acf62ba7ff7@mail.gmail.com>
	<2a41acea0706111333p5349993dg9315bfe8396f78a@mail.gmail.com>
	<466DB362.8010902@freebsd.org>
Cc: Sam Leffler <sam@errno.com>, src-committers@freebsd.org,
	cvs-all@freebsd.org, cvs-src@freebsd.org
Subject: Re: cvs commit: src/sys/net if.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jun 2007 20:46:29 -0000

On 6/11/07, Andre Oppermann <andre@freebsd.org> wrote:
> Jack Vogel wrote:
> > On 6/11/07, Jack Vogel <jfvogel@gmail.com> wrote:
> >> On 6/11/07, Sam Leffler <sam@errno.com> wrote:
> >> > Andre Oppermann wrote:
> >> > > andre       2007-06-11 20:08:12 UTC
> >> > >
> >> > >   FreeBSD src repository
> >> > >
> >> > >   Modified files:
> >> > >     sys/net              if.h
> >> > >   Log:
> >> > >   Add IFCAP_LRO flag for drivers to announce their TCP Large
> >> Receive Offload
> >> > >   capabilities.
> >> > >
> >> > >   Revision  Changes    Path
> >> > >   1.108     +1 -0      src/sys/net/if.h
> >> > > http://cvsweb.FreeBSD.org/src/sys/net/if.h.diff?r1=1.107&r2=1.108
> >> > >
> >> > >
> >> > There are many offload capabilities defined that are not well thought
> >> > out.  In particular we do not distinguish between ipv4 and ipv6 for
> >> > things like cksum and tso so there's no way to disable individual
> >> > features.  The ability to tweak LRO is clearly needed and clearly
> >> belong
> >> > as an ifnet capability but unilateraly deciding this is the wrong
> >> approach.
> >> >
> >> >         Sam
> >>
> >> We do distinguish between TSO4 and TSO6, its just that all the pieces
> >> for 6 arent actually there yet, you are right about the cksum
> >> granularity,
> >> but I'm not convinced its needed. You might be right on the need to
> >> fine tune the functionality, but having a big ON/OFF doesnt seem a
> >> bad thing to me.
> >
> > Oh, one other useful tidbit, for Oplin when RSS is enabled you can't do
> > CKSUM anyway, they reuse bits.
>
> What is Oplin?

Our new 10G adapter, er, its code name, its really 82598.