From owner-freebsd-ports@FreeBSD.ORG Sat May 30 14:32:01 2009 Return-Path: Delivered-To: ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2FCEF106564A; Sat, 30 May 2009 14:32:01 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from server.mypc.hu (server.mypc.hu [87.229.73.95]) by mx1.freebsd.org (Postfix) with ESMTP id D83B58FC0A; Sat, 30 May 2009 14:32:00 +0000 (UTC) (envelope-from gabor@FreeBSD.org) Received: from localhost (localhost [127.0.0.1]) by server.mypc.hu (Postfix) with ESMTP id 18FE114D5D63; Sat, 30 May 2009 16:15:33 +0200 (CEST) X-Virus-Scanned: amavisd-new at t-hosting.hu Received: from server.mypc.hu ([127.0.0.1]) by localhost (server.mypc.hu [127.0.0.1]) (amavisd-new, port 10024) with LMTP id lgKqfN32SnfH; Sat, 30 May 2009 16:15:32 +0200 (CEST) Received: from [192.168.1.105] (catv-80-98-231-64.catv.broadband.hu [80.98.231.64]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by server.mypc.hu (Postfix) with ESMTPSA id 99F2914D2545; Sat, 30 May 2009 16:15:32 +0200 (CEST) Message-ID: <4A213F84.1000704@FreeBSD.org> Date: Sat, 30 May 2009 16:15:32 +0200 From: Gabor Kovesdan User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Ed Schouten References: <20090529123633.GM48776@hoeg.nl> <20090530140800.GR48776@hoeg.nl> In-Reply-To: <20090530140800.GR48776@hoeg.nl> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit Cc: ports@FreeBSD.org, gerald@FreeBSD.org Subject: Re: [Patch] Proposal: USE_GNU89 switch X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 30 May 2009 14:32:01 -0000 Ed Schouten escribió: > Hi, > > I'm proposing the following patch: > > --- bsd.port.mk > +++ bsd.port.mk > @@ -2180,6 +2180,10 @@ > .endif > .endif > > +.if defined(USE_CSTD) > +CFLAGS+= -std=${USE_CSTD} > +.endif > + > # Multiple make jobs support > .if defined(DISABLE_MAKE_JOBS) || defined(MAKE_JOBS_UNSAFE) > _MAKE_JOBS= # > > I thought it would be better to add USE_CSTD, instead of USE_GNU89, > where the port itself can specify which C standard to use. This will > also allow us to force builds with -std=gnu99 when needed, for example. > > Any comments? Anyone who wants to integrate this patch into CVS, or > should I do it? > I don't think it's a good idea. This knob is completely superfluous and thus should be avoided. One can just add -std to CFLAGS from a port Makefile. Forced build are also possible without this stuff, you can set this in /etc/make.conf. Cheers, -- Gabor Kovesdan FreeBSD Volunteer EMAIL: gabor@FreeBSD.org .:|:. gabor@kovesdan.org WEB: http://people.FreeBSD.org/~gabor .:|:. http://kovesdan.org