Date: Mon, 3 Aug 2020 11:05:47 +0200 From: Stefan Esser <se@freebsd.org> To: Mathieu Arnold <mat@freebsd.org>, Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r543919 - head/astro/xearth/files Message-ID: <2a54f09c-2ed7-336d-2535-0fddfb0826de@freebsd.org> In-Reply-To: <20200803080504.3kzs5n7iapg7sajb@aching.in.mat.cc> References: <202008011830.071IUpJC086718@repo.freebsd.org> <20200803075524.tvfjcaxbbdd7lwgo@aching.in.mat.cc> <20200803080034.GA74839@FreeBSD.org> <20200803080504.3kzs5n7iapg7sajb@aching.in.mat.cc>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 03.08.20 um 10:05 schrieb Mathieu Arnold: > On Mon, Aug 03, 2020 at 08:00:34AM +0000, Alexey Dokuchaev wrote: >> On Mon, Aug 03, 2020 at 09:55:24AM +0200, Mathieu Arnold wrote: >>> On Sat, Aug 01, 2020 at 06:30:51PM +0000, Stefan E?er wrote: >>>> New Revision: 543919 >>>> URL: https://svnweb.freebsd.org/changeset/ports/543919 >>>> >>>> Log: >>>> Fix format: 2 missing commas after the longitude and white space in the >>>> name fields >>> >>> Space in the name fields are there so that names not in the same >>> location but close to one another do not overlap. I am not sure >>> removing them is a great idea. >> >> Abusing spaces for that matter is wrong; the port should be fixed instead >> of relying on manual alignment with spaces. >> >> Please do not taint raw data with its physical representation gimmicks. > > When given the choice between spending 5 seconds adding 3 spaces to make > it look good, or spending a day fixing antique software, I will always > choose 5 seconds (as I don't know C that much, or X programming at all, > it would be more like at least a week). The blanks have been added back in r544041, but I could not check the visual appearance since I'm currently connected over a SSH session without the possibility to start a local X11 server. > If you have the time to fix xearth, feel free to do it, but do not > assume people will have the time, will, or knowledge required to do so. This is an old program and I doubt there is much interest in fixing it - but it might be a relatively simple change and I'll see whether I get to adding an alignment pass after loading the marker data that offsets overloading entries before they are processed for display. That should not be too hard, but it has been (literally) decades since I last have dealt with a plain X11 program ...
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?2a54f09c-2ed7-336d-2535-0fddfb0826de>