From owner-freebsd-ports  Wed Oct 18  6:40: 6 2000
Delivered-To: freebsd-ports@freebsd.org
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 473DF37B4E5
	for <freebsd-ports@FreeBSD.org>; Wed, 18 Oct 2000 06:40:01 -0700 (PDT)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.9.3/8.9.2) id GAA21539;
	Wed, 18 Oct 2000 06:40:01 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: from adelie.btinternet.com (host212-140-200-211.btinteractive.net [212.140.200.211])
	by hub.freebsd.org (Postfix) with ESMTP id EE53E37B4E5
	for <FreeBSD-gnats-submit@freebsd.org>; Wed, 18 Oct 2000 06:30:26 -0700 (PDT)
Received: (from oh@localhost)
	by adelie.btinternet.com (8.9.3/8.9.3) id OAA22235;
	Wed, 18 Oct 2000 14:30:17 +0100 (BST)
	(envelope-from oh)
Message-Id: <200010181330.OAA22235@adelie.btinternet.com>
Date: Wed, 18 Oct 2000 14:30:17 +0100 (BST)
From: oh@btinternet.com
Reply-To: O.Hodson@cs.ucl.ac.uk
To: FreeBSD-gnats-submit@freebsd.org
X-Send-Pr-Version: 3.2
Subject: ports/22082: ports/mbone/rat patch
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org


>Number:         22082
>Category:       ports
>Synopsis:       Patch to remove mixer vol control from inputs
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Wed Oct 18 06:40:01 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Orion Hodson
>Release:        FreeBSD 4.1-RELEASE i386
>Organization:
University College London
>Environment:

	

>Description:

newpcm reports the mixer vol control as an input, but it is an output
control.  There are some configurations of rat that will set vol to
zero thinking it's an input, resulting in the user not hearing audio
being received.  This patch removes vol from the driver reported
inputs.

>How-To-Repeat:

	

>Fix:

The patch file below contains patch-ae that fixes the problem.  It is
a new file and will need to be cvs added after running patch.

Thanks
- Orion.

diff -uPr mbone/rat-pre-mixer-vol-patch/files/patch-ae mbone/rat/files/patch-ae
--- mbone/rat-pre-mixer-vol-patch/files/patch-ae	Thu Jan  1 01:00:00 1970
+++ mbone/rat/files/patch-ae	Wed Oct 18 14:11:13 2000
@@ -0,0 +1,20 @@
+--- rat/auddev_pcm.c.orig	Wed Oct 18 14:08:46 2000
++++ rat/auddev_newpcm.c	Wed Oct 18 14:09:55 2000
+@@ -9,7 +9,7 @@
+  
+ #ifndef HIDE_SOURCE_STRINGS
+ static const char cvsid[] = 
+-	"$Id: auddev_newpcm.c,v 1.1 2000/09/16 17:43:23 ucacoxh Exp $";
++	"$Id: auddev_newpcm.c,v 1.3 2000/10/18 11:15:42 ucacoxh Exp $";
+ #endif /* HIDE_SOURCE_STRINGS */
+ 
+ #include "config_unix.h"
+@@ -291,6 +291,8 @@
+ 
+ 	NEWPCM_AUDIO_IOCTL(fd, SOUND_MIXER_READ_RECMASK, &recmask);
+ 
++	/* Remove Vol from Rec mask - it is a play control! */
++	recmask = recmask & ~SOUND_MASK_VOLUME;
+ 	if (recmask & SOUND_MASK_MIC) {
+ 		iport = SOUND_MASK_MIC;
+ 	} else {



>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message