From owner-freebsd-current@freebsd.org Tue Jul 16 15:11:27 2019 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 33817B1EAC for ; Tue, 16 Jul 2019 15:11:27 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CCF1789290 for ; Tue, 16 Jul 2019 15:11:25 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qk1-x72d.google.com with SMTP id s22so14838991qkj.12 for ; Tue, 16 Jul 2019 08:11:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HS6JEBn4eDljpRMZpFYlLCTWOpc+sB0X2g5gHu3LRZ0=; b=Sib0bWePJV/5jqdxu64IFDp0aol6Uiuy6C/M5rcR6vqkVqJku/shs+VFH5+dPB2i7r m2lWub2e3Tm/N62TTbmq96ocO+zqtZAfrgq3m7LSjDUmxJKpruthAP7/CvYGjgnorFTS IrQo3ZgV1aiQA+74Teeg9qKd4tP+940UH6zBDOjrhkOPrv65QW2ng7vE2iX5KOQUbShI /7NnClVM8pq3gCZDhFYIOS9Q7RfZ71LYJbDx+BxioZHGpGgBFhTx8qusDvTkaH9LpY8h jPuMeuy2pwnqivH453a8tlvbzC2wYOvq/d9UUsvXbKtH4T+HOO5d0im04Uh5Nq0cOdfr daJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HS6JEBn4eDljpRMZpFYlLCTWOpc+sB0X2g5gHu3LRZ0=; b=sONIG6QJA9TdF3sBn2h/PR5YxZGyNMpGvXHugrGf7RA95CgKck6090d9+BSwTo+2eo ZZx1/Kit1jL28A30gNj8y9c+I+vksfD3HaIAh/p8fQa0dBRUa+4DeCgPaMTd8LdOw0zU X68Jy5bL7j4VatPNjgKaUuWi6yTkM1B5iMM7whojW35ctmocxlNEzQoUQ4owNJ6F3ml6 JXSGG4DvfGaCsNEeBh+mKetPQdjz8l4jwYNU6Xo5vC1VolRZ0v71R5RW3qv2oRPgYP/2 iLiiYPAn4Tkoxx6H3qQUWfZrFdpfuQWZcWzPA0qXe/JYbo3Sa1Nawk+YvBdVseKtiLpi oB2g== X-Gm-Message-State: APjAAAXSGjkDJUHE+2M2uMs+d6KAmVeG4Y6AtjTxTSHdRUfupjQg4Zm7 uBtnpzY+h4jBCzNq8gnCdpJNjv3sq6TWFZZqI9Y= X-Google-Smtp-Source: APXvYqxc/WQGSPW/cweLE3mzlXMyiT+AXeOhWJS9gJvRfAcPoggmUyIUImlfaMR/0gnnqMb3AGLXXufFudCc79SCAwQ= X-Received: by 2002:ae9:f107:: with SMTP id k7mr22712164qkg.215.1563289885038; Tue, 16 Jul 2019 08:11:25 -0700 (PDT) MIME-Version: 1.0 References: <4248209b-cbd0-93df-b362-3887270e9c99@blastwave.org> <4d363c47-2cf0-add4-da6e-ea9f023b5d67@blastwave.org> In-Reply-To: From: Warner Losh Date: Tue, 16 Jul 2019 09:11:13 -0600 Message-ID: Subject: Re: sbin/camcontrol/camcontrol.c error breaks buildworld To: Dennis Clarke Cc: Dimitry Andric , FreeBSD CURRENT X-Rspamd-Queue-Id: CCF1789290 X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=Sib0bWeP X-Spamd-Result: default: False [-5.57 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-0.96)[-0.957,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-current@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; MX_GOOD(-0.01)[cached: ALT1.aspmx.l.google.com]; RCVD_IN_DNSWL_NONE(0.00)[d.2.7.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_SHORT(-0.58)[-0.585,0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+]; RCVD_TLS_LAST(0.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; IP_SCORE(-3.02)[ip: (-9.42), ipnet: 2607:f8b0::/32(-3.17), asn: 15169(-2.45), country: US(-0.06)]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Jul 2019 15:11:27 -0000 On Tue, Jul 16, 2019 at 5:04 AM Dennis Clarke wrote: > On 7/16/19 6:55 AM, Dimitry Andric wrote: > > On 16 Jul 2019, at 12:36, Dennis Clarke wrote: > >> > >> On 7/16/19 2:48 AM, Warner Losh wrote: > >>> On Tue, Jul 16, 2019 at 12:07 AM Dennis Clarke > >>> wrote: > >>>> /usr/src/r350018/sbin/camcontrol/camcontrol.c: In function > 'getdevtype': > >>>> /usr/src/r350018/sbin/camcontrol/camcontrol.c:679: warning: comparison > >>>> of unsigned expression < 0 is always false > >>>> > >>>> Anyone else seeing this ? > >>>> > >>> Fixed hours ago in 350020. > >> > >> Hours ago. Cool. However is there no CI testing on ppc64? > > > > There is a CI build, in any case: > > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/ > > > > It showed a failure for build #11532 (r350018): > > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11532/ > > > > and also how it got fixed in build #11533 (r350020): > > https://ci.freebsd.org/job/FreeBSD-head-powerpc64-build/11533/ > > > > Unfortunately there is no test job which attempts to fire up a world > > inside e.g. qemu. > > Oh well, thank you for the info. Lucky me that I fell into the exact > same build problem which only happens rarely. Hardly a lottery ticket > win but I am happy to see the CI information. > The window would have been smaller. CI detected the breakage within 10 minutes, but I was away from my email attending to some household things for an hour more... Warner