Date: Fri, 10 Nov 2000 11:23:56 +0100 From: Adrian Chadd <adrian@FreeBSD.org> To: Bruce Evans <bde@zeta.org.au> Cc: Clive Lin <clive@CirX.ORG>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sbin/badsect badsect.c Message-ID: <20001110112354.A24560@roaming.cacheboy.net> In-Reply-To: <Pine.BSF.4.21.0011092300120.8223-100000@besplex.bde.org>; from bde@zeta.org.au on Thu, Nov 09, 2000 at 11:35:08PM %2B1100 References: <20001109173927.B67472@educampus.ncl.edu.tw> <Pine.BSF.4.21.0011092300120.8223-100000@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Nov 09, 2000, Bruce Evans wrote: > On Thu, 9 Nov 2000, Clive Lin wrote: > > > Is it ok to close this PR ? bde talks too much , more than I could > > catch :( > > > > http://www.FreeBSD.org/cgi/query-pr.cgi?pr=19574 > > My point in the followup about lots of dead code still applies. badsect > used a readdir() loop instead of just statfs() because it wanted to find > the character device corresponding to the mounted-on block device and > not just the mounted-on device. This is now bogus. > Yup, I noticed this. I will look at tidying up the code as per your notes, but I wanted to get it working (and easily MFCed for 4.2) before doing a thorough tidy-up. adrian -- Adrian Chadd "Programming is like sex: <adrian@freebsd.org> One mistake and you have to support for a lifetime." -- rec.humor.funny To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20001110112354.A24560>