From owner-cvs-all Wed Feb 7 12:47:48 2001 Delivered-To: cvs-all@freebsd.org Received: from vilnya.demon.co.uk (vilnya.demon.co.uk [158.152.19.238]) by hub.freebsd.org (Postfix) with ESMTP id 2729B37B401; Wed, 7 Feb 2001 12:47:20 -0800 (PST) Received: from haveblue (haveblue.rings [10.2.4.5]) by vilnya.demon.co.uk (Postfix) with SMTP id BA722D9B8; Wed, 7 Feb 2001 20:46:57 +0000 (GMT) Message-ID: <002101c09147$1c2b7710$0504020a@haveblue> From: "Cameron Grant" To: "Cameron Grant" , "Peter Wemm" Cc: , References: <200102071433.f17EXmt64539@mobile.wemm.org> Subject: Re: Broken PCM - Re: cvs commit: src/sys/dev/sound/pcm channel.c Date: Wed, 7 Feb 2001 20:46:56 -0000 MIME-Version: 1.0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 7bit X-Priority: 3 X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook Express 5.50.4133.2400 X-MimeOLE: Produced By Microsoft MimeOLE V5.50.4133.2400 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > I dont think you meant to commit all this stuff.. It breaks the kernel > pretty badly. pcm_channel doesn't have the mutexes yet. no, i didn't. i have no idea how this code came to be in the tree i committed from. or, at least, the tree i thought i committed from. > Your MFC said "merge rev 1.49" which was a couple of lines at the most, so > I think you accidently committed this stuff. I backed out the change locally > and hand-applied the MFC'ed patches to rev 1.48 and it seems to work fine. i've just committed 1.50 which is what 1.49 should have been. -cg To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message