From owner-svn-src-head@freebsd.org Tue Aug 30 16:04:01 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 42610BC8594; Tue, 30 Aug 2016 16:04:01 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi0-x234.google.com (mail-oi0-x234.google.com [IPv6:2607:f8b0:4003:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 080BB286C; Tue, 30 Aug 2016 16:04:01 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oi0-x234.google.com with SMTP id f189so32284393oig.3; Tue, 30 Aug 2016 09:04:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=b6frV3wyBEJ2GfZn8EYr+ojzwMd3uwgIHKU9SsqnAx4=; b=IcU4CMMRVvicC0FFk1rBDKgPgb334hhrdeyKw6s8r4Pgrag8FLEmIEMtsC+hV79z/M 0+V/J8qQpm5ra7hBvwss8uPqoToqY/pui1e+fcVlV6+DxZX+sxY40OlQMNZ4ZE7M14Zy rzFSGTubQhyv801yh3lD4TelSRdXrEzjromaYbT/uNSjhuJGJZAUyJojSUtHRhJF/o1H IKQOuI6F118ZRPqLeNsOZf0T4+WJLtIG/2OoNjg+P2EIlDtuVoigenvD693eZ7uSU0p4 9F/ZJDlnHosnIkKFA6Vc6YnGpDQCvb5wvuA3VZwdykHbdHjK7V21rVqFz+kNpbvWsLVf hoDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=b6frV3wyBEJ2GfZn8EYr+ojzwMd3uwgIHKU9SsqnAx4=; b=dIpQ1za4CSkSdsgY9vKTp5n0qmPIECCSRuWbAor6Xlk8j8rKImxk9Sem3UK8QAVOLE z22te3nLImi7pI9sUpOiEXcDSbbO+4Ntfqhf5rplAT9Y/ZDdR+5EzgMxZ7vv8jOKSrM7 cmNUxaKbYarqrSUlcugbE/EV1gKjVpHHwyK5cknl4NNLwPvLqOiiROpydyt3vkPaG8ZH gOgJy4TXn5MsazyGeYOqeAlgtEdh0xuvni7/15IAr8cHYYX/rNbA3Lyii3uT+841AWwr 32xkIhwKvBV3HujXfZOBL96n3g/1e99uIqSJy7TOMGh45JPEwNP3qTn+cW+e45X/pOm9 wwbg== X-Gm-Message-State: AE9vXwM9215zF0uzcdXHvrvdg6FzbAkKQq5ljPEaiovEZcErYm0sHD59RVhIttv2On0sjyDpu3utNOgNcDFXAA== X-Received: by 10.202.66.133 with SMTP id p127mr4760535oia.174.1472573040116; Tue, 30 Aug 2016 09:04:00 -0700 (PDT) MIME-Version: 1.0 Sender: asomers@gmail.com Received: by 10.202.196.149 with HTTP; Tue, 30 Aug 2016 09:03:59 -0700 (PDT) In-Reply-To: <201608170124.u7H1OYXQ070590@repo.freebsd.org> References: <201608170124.u7H1OYXQ070590@repo.freebsd.org> From: Alan Somers Date: Tue, 30 Aug 2016 10:03:59 -0600 X-Google-Sender-Auth: 7WLn13dtKDd4FWAouasc6Mvfjxs Message-ID: Subject: Re: svn commit: r304246 - head/sys/dev/pci To: Eric van Gyzen Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Aug 2016 16:04:01 -0000 On Tue, Aug 16, 2016 at 7:24 PM, Eric van Gyzen wrote: > Author: vangyzen > Date: Wed Aug 17 01:24:34 2016 > New Revision: 304246 > URL: https://svnweb.freebsd.org/changeset/base/304246 > > Log: > PCIe HotPlug: Detect bridges that are not really HotPlug capable > > Some devices report that they have an MRL when they actually > do not. Since they always report that the MRL is open, child > devices would be ignored. Try to detect these devices and > ignore their claim of HotPlug support. Specifically, > if there is an open MRL but the Data Link Layer is active, > the MRL is not real. > > Revert r303645 to re-enable HotPlug support for slots with > power controllers, since it works correctly in my testing. > > Start the DLL state-change timer if Presence /or/ MRL state changes, > along with other conditions. Previously, we started the timer iff > Presence changed. If there is an MRL, it must be closed for power > to be turned on, so Presence is unlikely to change on an MRL-close event. > > Add a printf() of interesting registers on HotPlug interrupts and > commands (one from erj@). These were very useful for debugging. > Guard them with bootverbose, since they're spam in normal operation. > > In collaboration with: jhb > Reviewed by: jhb > MFC after: 1 day > Relnotes: yes (re-enable HotPlug support for slots with power controllers) > Sponsored by: Dell Inc. > Differential Revision: https://reviews.freebsd.org/D7509 > > Modified: > head/sys/dev/pci/pci_pci.c > I suspect that this has caused a regression for a Dell CS23-SH. It worked on stable/11 at r303879 but in 11.0 RC2 it hangs on boot. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211699 .