From owner-cvs-all@FreeBSD.ORG  Mon Jun 11 20:52:07 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
X-Original-To: cvs-all@FreeBSD.org
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4694016A400;
	Mon, 11 Jun 2007 20:52:07 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id 035C213C448;
	Mon, 11 Jun 2007 20:52:06 +0000 (UTC) (envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.13.8/8.13.4) with ESMTP id l5BKo2uu050232;
	Mon, 11 Jun 2007 14:50:02 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Mon, 11 Jun 2007 14:50:26 -0600 (MDT)
Message-Id: <20070611.145026.-1303462192.imp@bsdimp.com>
To: sam@errno.com
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <466DAD3E.7090106@errno.com>
References: <200706111934.l5BJYr9O095451@repoman.freebsd.org>
	<466DAD3E.7090106@errno.com>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0
	(harmony.bsdimp.com [127.0.0.1]);
	Mon, 11 Jun 2007 14:50:03 -0600 (MDT)
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/net80211 ieee80211_radiotap.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 11 Jun 2007 20:52:07 -0000

In message: <466DAD3E.7090106@errno.com>
            Sam Leffler <sam@errno.com> writes:
: Warner Losh wrote:
: > imp         2007-06-11 19:34:53 UTC
: > 
: >   FreeBSD src repository
: > 
: >   Modified files:
: >     sys/net80211         ieee80211_radiotap.h 
: >   Log:
: >   Prefer __packed to __attribute__((__packed__)).
: >   
: >   OK'd by sam@ months ago...
: >   
: >   Revision  Changes    Path
: >   1.9       +1 -1      src/sys/net80211/ieee80211_radiotap.h
: > http://cvsweb.FreeBSD.org/src/sys/net80211/ieee80211_radiotap.h.diff?r1=1.8&r2=1.9
: > 
: > 
: This file is included in user code.  Is __packed commonly visible?

Yes.  Nothing that includes any kernel file could not have it defined
and visible, afaik.

: FWIW I've avoided tweaking this file as much as possible because of it's 
: shared heritage w/ netbsd.

I'll be happy to revert it.  I'm pretty sure the last time we talked
about it you said it was OK, however.  Maybe my memory is faulty, or
maybe things have changed.  I'll back it out if either of those are
the case if you think it is bad...

Warner