From owner-svn-src-head@freebsd.org Wed Nov 13 23:17:18 2019 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 140061BEF1B; Wed, 13 Nov 2019 23:17:18 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47D0rF4jd5z44XH; Wed, 13 Nov 2019 23:17:17 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id xADNH91v096189 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Thu, 14 Nov 2019 01:17:12 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua xADNH91v096189 Received: (from kostik@localhost) by tom.home (8.15.2/8.15.2/Submit) id xADNH90B096188; Thu, 14 Nov 2019 01:17:09 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Thu, 14 Nov 2019 01:17:09 +0200 From: Konstantin Belousov To: Brooks Davis Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r354694 - in head: lib/libc/gen sys/sys Message-ID: <20191113231709.GY2707@kib.kiev.ua> References: <201911132151.xADLptvc074883@repo.freebsd.org> <20191113224640.GX2707@kib.kiev.ua> <20191113225535.GA17978@spindle.one-eyed-alien.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191113225535.GA17978@spindle.one-eyed-alien.net> User-Agent: Mutt/1.12.2 (2019-09-21) X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on tom.home X-Rspamd-Queue-Id: 47D0rF4jd5z44XH X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-5.99 / 15.00]; NEURAL_HAM_MEDIUM(-0.99)[-0.987,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Nov 2019 23:17:18 -0000 On Wed, Nov 13, 2019 at 10:55:35PM +0000, Brooks Davis wrote: > On Thu, Nov 14, 2019 at 12:46:40AM +0200, Konstantin Belousov wrote: > > On Wed, Nov 13, 2019 at 09:51:55PM +0000, Brooks Davis wrote: > > > Author: brooks > > > Date: Wed Nov 13 21:51:55 2019 > > > New Revision: 354694 > > > URL: https://svnweb.freebsd.org/changeset/base/354694 > > > > > > Log: > > > elf_aux_info: Add support for AT_EXECPATH. > > > > > > Reviewed by: emaste, sef > > > MFC after: 3 days > > > Sponsored by: DARPA, AFRL > > > Differential Revision: https://reviews.freebsd.org/D22353 > > > > > > Modified: > > > head/lib/libc/gen/auxv.3 > > > head/lib/libc/gen/auxv.c > > > head/sys/sys/param.h > > > > > > Modified: head/lib/libc/gen/auxv.3 > > > ============================================================================== > > > --- head/lib/libc/gen/auxv.3 Wed Nov 13 21:49:46 2019 (r354693) > > > +++ head/lib/libc/gen/auxv.3 Wed Nov 13 21:51:55 2019 (r354694) > > > @@ -24,7 +24,7 @@ > > > .\" > > > .\" $FreeBSD$ > > > .\" > > > -.Dd April 25, 2019 > > > +.Dd November 13, 2019 > > > .Dt ELF_AUX_INFO 3 > > > .Os > > > .Sh NAME > > > @@ -48,6 +48,10 @@ can be requested: > > > .Bl -tag -width AT_OSRELDATE > > > .It AT_CANARY > > > The canary value for SSP. > > > +.It AT_EXECPATH > > > +The path of executed program. > > > +This will not be present if the process was initialized by > > This is too strong statement. The auxv element might be not present > > if vn_fullpath(9) failed, otherwise we do provide the path. > > > > > +.Xr fexecve 2 . > > Would it be more accurate to change it from "will" to "may"? > Referencing vn_fullpath(9) seems unhelpful in userspace programmer > documentation. I do not suggest to reference vn_fullpath(9). 'May' is enough, you might also mention namecache.