Date: Sun, 13 Nov 2011 10:45:35 +0000 From: Chris Rees <crees@freebsd.org> To: Baptiste Daroussin <bapt@freebsd.org>, Ed Schouten <ed@80386.nl>, matthew@cashdollar.org Cc: cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org Subject: Re: cvs commit: ports/shells/zsh/files patch-Src_watch.c Message-ID: <CADLo83-9jpoKccjRV2Fs8Ups1OTj7FQsFGA2UABZY280fjxfRA@mail.gmail.com> In-Reply-To: <201111130956.pAD9u85M053975@repoman.freebsd.org> References: <201111130956.pAD9u85M053975@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 13 November 2011 09:56, Baptiste Daroussin <bapt@freebsd.org> wrote: > bapt =A0 =A0 =A0 =A02011-11-13 09:56:08 UTC > > =A0FreeBSD ports repository > > =A0Added files: > =A0 =A0shells/zsh/files =A0 =A0 patch-Src_watch.c > =A0Log: > =A0- Fix build for badly upgraded systems which have both utmp.h and utmp= x.h > > =A0PR: =A0 =A0 =A0 =A0 =A0 =A0 ports/156263 =A0http://www.FreeBSD.org/cgi= /query-pr.cgi?pr=3D156263 > =A0Submitted by: =A0 Matthew Cashdollar <matthew@cashdollar.org> > =A0Feature safe: =A0 yes > Fixing it here will only mask the problem-- why are we adding a fix to support a broken system? The proper solution is to rm utmp.h in that system, is it not? I suggest a different patch at [1]. Chris [1] http://www.bayofrum.net/~crees/patches/zsh-utmpx-fix.diff.txt [removing the patchfile too]
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CADLo83-9jpoKccjRV2Fs8Ups1OTj7FQsFGA2UABZY280fjxfRA>