From owner-cvs-src@FreeBSD.ORG Thu Jan 22 00:37:21 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 19A4516A4CE; Thu, 22 Jan 2004 00:37:21 -0800 (PST) Received: from telecom.net.et (ns2.telecom.net.et [213.55.64.38]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0D77C43D76; Thu, 22 Jan 2004 00:36:27 -0800 (PST) (envelope-from mtm@identd.net) Received: from [213.55.65.189] (HELO pool-151-200-10-97.res.east.verizon.net) by telecom.net.et (CommuniGate Pro SMTP 3.4.8) with ESMTP-TLS id 34879203; Thu, 22 Jan 2004 11:30:55 +0300 Received: from mobile.acsolutions.com (localhost [127.0.0.1]) ESMTP id i0M8aGca001631; Thu, 22 Jan 2004 11:36:18 +0300 (EAT) (envelope-from mtm@mobile.acsolutions.com) Received: (from mtm@localhost) by mobile.acsolutions.com (8.12.10/8.12.10/Submit) id i0M8aFTL001630; Thu, 22 Jan 2004 11:36:15 +0300 (EAT) (envelope-from mtm) Date: Thu, 22 Jan 2004 11:36:13 +0300 From: Mike Makonnen To: Colin Percival Message-ID: <20040122083613.GA1613@mobile.acsolutions.com> References: <200401211643.i0LGhT43093728@repoman.freebsd.org> <20040122074937.GB1013@mobile.acsolutions.com> <6.0.1.1.1.20040122082056.04321990@imap.sfu.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6.0.1.1.1.20040122082056.04321990@imap.sfu.ca> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD/5.2-CURRENT (i386) cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/fs/devfs devfs_rule.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Jan 2004 08:37:21 -0000 On Thu, Jan 22, 2004 at 08:28:41AM +0000, Colin Percival wrote: > At 07:49 22/01/2004, Mike Makonnen wrote: > >On Wed, Jan 21, 2004 at 08:43:29AM -0800, Colin Percival wrote: > >> Allow devfs path rules to work on directories. Without this fix, > >> devfs rule add path fd unhide > >> is a no-op, while it should unhide the fd subdirectory. > > > >Does this affect /etc/defaults/devfs.rules? > > No, but we might want to change devfs.rules. > > >I am assuming that the 'add hide' in the first ruleset will now also > >hide /dev/fd (where it previously didn't). > > The 'add hide' was always hiding /dev/fd. It just wasn't possible > to unhide it without unhiding everything. (devfs_rule_matchpath is > only called if the rule specifies a path; prior to this fix, it would > always return "no, this doesn't match" when applied to a directory.) > > >In that case will the > >'add path fd/* unhide' in a later rule unhide the fd/ directory? Does > >it need a separate 'add fd unhide'? > > Given that 'add path fd/* unhide' currently unhides entries within > a hidden directory, it would probably makes sense to add a separate > 'add path fd unhide'. :) Please do so then. Thanks. Cheers. -- Mike Makonnen | GPG-KEY: http://www.identd.net/~mtm/mtm.asc mtm@identd.net | Fingerprint: 00E8 61BC 0D75 7FFB E4D3 6BF1 B239 D010 3215 D418 mtm@FreeBSD.Org| FreeBSD - Unleash the Daemon !