Date: Tue, 07 Apr 2009 10:13:08 -0700 From: Xin LI <delphij@delphij.net> To: John Baldwin <jhb@FreeBSD.ORG> Cc: svn-src-head@FreeBSD.ORG, svn-src-all@FreeBSD.ORG, src-committers@FreeBSD.ORG, Xin LI <delphij@FreeBSD.ORG> Subject: Re: svn commit: r190810 - head/sys/dev/hptmv Message-ID: <49DB89A4.4080507@delphij.net> In-Reply-To: <200904071307.29778.jhb@freebsd.org> References: <200904071640.n37GeWGb014706@svn.freebsd.org> <200904071307.29778.jhb@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 John Baldwin wrote: > On Tuesday 07 April 2009 12:40:32 pm Xin LI wrote: >> Author: delphij >> Date: Tue Apr 7 16:40:31 2009 >> New Revision: 190810 >> URL: http://svn.freebsd.org/changeset/base/190810 >> >> Log: >> When multiple cards are present, register a shutdown handler for each card >> instead of just register one for the first adapter. Without doing this >> there would be some data loss upon shutdown because data could be ignored >> when flushing to disk. > > Have you considered just using a device_shutdown routine? It is invoked at > shutdown_final as well but is easier to use (no need to keep track of > eventhandler tags, etc.). Yes for sure. What I really wanted to do is to keep the change as few as possible at this point, as the requester for update has tested his patch (slightly different) and we are approaching 7.2-RELEASE... Cheers, - -- Xin LI <delphij@delphij.net> http://www.delphij.net/ FreeBSD - The Power to Serve! -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.11 (FreeBSD) iEYEARECAAYFAknbiaMACgkQi+vbBBjt66C+bACgvECvXYtfJRrgsl+5wDSXe3ty EOEAn3iL1o7OegT4A2P/T3o9fJ/5UvLT =bvSu -----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?49DB89A4.4080507>