Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 3 Jul 2018 13:09:34 -0700
From:      Bryan Drewery <bdrewery@FreeBSD.org>
To:        Cy Schubert <Cy.Schubert@cschubert.com>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r335908 - head/sys/conf
Message-ID:  <bf1f68d2-a45e-c356-c6b9-cd1c6449cd8e@FreeBSD.org>
In-Reply-To: <201807032006.w63K6c3E069211@slippy.cwsent.com>
References:  <201807032006.w63K6c3E069211@slippy.cwsent.com>

next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156)
--5LBlvAHx6wd2MBY6ZJGLCKfNccUC2f3P7
Content-Type: multipart/mixed; boundary="FxkUanNxVoyIpem522qWwd6g1GQCAsxqA";
 protected-headers="v1"
From: Bryan Drewery <bdrewery@FreeBSD.org>
To: Cy Schubert <Cy.Schubert@cschubert.com>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Message-ID: <bf1f68d2-a45e-c356-c6b9-cd1c6449cd8e@FreeBSD.org>
Subject: Re: svn commit: r335908 - head/sys/conf
References: <201807032006.w63K6c3E069211@slippy.cwsent.com>
In-Reply-To: <201807032006.w63K6c3E069211@slippy.cwsent.com>

--FxkUanNxVoyIpem522qWwd6g1GQCAsxqA
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 7/3/2018 1:06 PM, Cy Schubert wrote:
> In message <201807032003.w63K3JD3071764@repo.freebsd.org>, Bryan=20
> Drewery writes
> :
>> Author: bdrewery
>> Date: Tue Jul  3 20:03:19 2018
>> New Revision: 335908
>> URL: https://svnweb.freebsd.org/changeset/base/335908
>>
>> Log:
>>   Fix r335906+r335907 to not pass multiple source files to genoffset_t=
est.o t
>> arget.
>>  =20
>>   This is working around a bug with the FAST_DEPEND logic with custom =
targets
>>   that use .ALLSRC.
>>  =20
>>   Reported by:	mmacy
>>
>> Modified:
>>   head/sys/conf/kern.post.mk
>>
>> Modified: head/sys/conf/kern.post.mk
>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> =3D
>> --- head/sys/conf/kern.post.mk	Tue Jul  3 19:24:52 2018	(r33590
>> 7)
>> +++ head/sys/conf/kern.post.mk	Tue Jul  3 20:03:19 2018	(r33590
>> 8)
>> @@ -195,8 +195,8 @@ genoffset.o: $S/kern/genoffset.c
>>  # is to exercise the CTASSERT that checks that the offsets in the off=
set.inc
>>  # _lite struct(s) match those in the original(s).=20
>>  genoffset_test.o: $S/kern/genoffset.c offset.inc
>> -	${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST ${.ALLSRC:M*.c}=
 \
>> -	    -o ${.TARGET}
>> +	${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST \
>> +	    $S/kern/genoffset.c -o ${.TARGET}
>=20
> This still won't build because of -c and -o.

-c is just a hint to the compiler to not run the linker. It's fine. We
even have this pattern used in share/mk/bsd.suffixes.mk.

>=20
>> =20
>>  assym.inc: $S/kern/genassym.sh genassym.o genoffset_test.o
>>  	NM=3D'${NM}' NMFLAGS=3D'${NMFLAGS}' sh $S/kern/genassym.sh genassym.=
o > ${.
>> TARGET}
>>
>=20
>=20


--=20
Regards,
Bryan Drewery


--FxkUanNxVoyIpem522qWwd6g1GQCAsxqA--

--5LBlvAHx6wd2MBY6ZJGLCKfNccUC2f3P7
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQEcBAEBAgAGBQJbO9f+AAoJEDXXcbtuRpfPLfMH/RGntxsu4DA4HCIHUB0CvC3g
P6Bg0v1Acx0IVKF8TN+x4Bue+q8JGckWj67g8CVkhi4w9YcpZUQk+yq+pzRL/lU3
qSF64+EPf77QV+gKgIfZWUTr1JASeIEbJ0D2XAafp4/DcjeSiTHUHWnebn9MyP/J
8p55s6OJb4aYY/dQxSTiakZ91I2+uIk28f3zo7SiFUOgxzugnFHrMnYIRqcikMyB
ir6aBYVKq4UqDusRb0cVgmm+hsI1yurao8sHz+kcrFt8awkiMw1y/FgVKRBdqbyh
XXP4R29pysHW7wy0OJU0rQC81EYIdXmrWpyGNdN1kwXxsRWwa++weR0zx+EtqEs=
=Vx2i
-----END PGP SIGNATURE-----

--5LBlvAHx6wd2MBY6ZJGLCKfNccUC2f3P7--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bf1f68d2-a45e-c356-c6b9-cd1c6449cd8e>