Date: Sat, 24 May 2003 14:04:19 -0700 From: Luigi Rizzo <luigi@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: freebsd-alpha@FreeBSD.org Subject: Re: [FEEDBACK REQUIRED] patch for ipfw/ipfw2 on alpha/sparc64 Message-ID: <20030524140419.A3621@xorpc.icir.org> In-Reply-To: <XFMail.20030524164415.jhb@FreeBSD.org>; from jhb@FreeBSD.org on Sat, May 24, 2003 at 04:44:15PM -0400 References: <20030524202652.68A9F2A7EA@canning.wemm.org> <XFMail.20030524164415.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 24, 2003 at 04:44:15PM -0400, John Baldwin wrote: ... > >> +#ifdef I386 > >> fs = ((ipfw_insn_pipe *)cmd)->pipe_ptr; > >> +#else > >> + bcopy(& ((ipfw_insn_pipe *)cmd)->pipe_ptr, &fs, sizeof(fs)); > >> +#endif > >> > > > > This is not a 'reviewed-by:', but these should be #ifdef __i386__ > > rather than #ifdef I386. > > Why is the #ifdef even there? Why not use bcopy all the time? performance maybe ? This particular one is called everytime you deliver a packet to a dummynet pipe. cheers luigi > -- > > John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ > "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030524140419.A3621>