From owner-freebsd-alpha@FreeBSD.ORG  Sat May 24 14:04:20 2003
Return-Path: <owner-freebsd-alpha@FreeBSD.ORG>
Delivered-To: freebsd-alpha@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 4B20D37B401; Sat, 24 May 2003 14:04:20 -0700 (PDT)
Received: from xorpc.icir.org (xorpc.icir.org [192.150.187.68])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 9A42F43F75; Sat, 24 May 2003 14:04:19 -0700 (PDT)
	(envelope-from rizzo@xorpc.icir.org)
Received: from xorpc.icir.org (localhost [127.0.0.1])
	by xorpc.icir.org (8.12.8p1/8.12.3) with ESMTP id h4OL4JQg003634;
	Sat, 24 May 2003 14:04:19 -0700 (PDT)
	(envelope-from rizzo@xorpc.icir.org)
Received: (from rizzo@localhost)
	by xorpc.icir.org (8.12.8p1/8.12.3/Submit) id h4OL4Jqe003633;
	Sat, 24 May 2003 14:04:19 -0700 (PDT)
	(envelope-from rizzo)
Date: Sat, 24 May 2003 14:04:19 -0700
From: Luigi Rizzo <luigi@FreeBSD.org>
To: John Baldwin <jhb@FreeBSD.org>
Message-ID: <20030524140419.A3621@xorpc.icir.org>
References: <20030524202652.68A9F2A7EA@canning.wemm.org>
	<XFMail.20030524164415.jhb@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5.1i
In-Reply-To: <XFMail.20030524164415.jhb@FreeBSD.org>;
	from jhb@FreeBSD.org on Sat, May 24, 2003 at 04:44:15PM -0400
cc: freebsd-alpha@FreeBSD.org
Subject: Re: [FEEDBACK REQUIRED] patch for ipfw/ipfw2 on alpha/sparc64
X-BeenThere: freebsd-alpha@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Porting FreeBSD to the Alpha <freebsd-alpha.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-alpha>,
	<mailto:freebsd-alpha-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-alpha>
List-Post: <mailto:freebsd-alpha@freebsd.org>
List-Help: <mailto:freebsd-alpha-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-alpha>,
	<mailto:freebsd-alpha-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 May 2003 21:04:20 -0000

On Sat, May 24, 2003 at 04:44:15PM -0400, John Baldwin wrote:
...
> >> +#ifdef I386
> >>      fs = ((ipfw_insn_pipe *)cmd)->pipe_ptr;
> >> +#else
> >> +    bcopy(& ((ipfw_insn_pipe *)cmd)->pipe_ptr, &fs, sizeof(fs));
> >> +#endif
> >>  
> > 
> > This is not a 'reviewed-by:', but these should be #ifdef __i386__
> > rather than #ifdef I386.
> 
> Why is the #ifdef even there?  Why not use bcopy all the time?

performance maybe ? This particular one is called everytime
you deliver a packet to a dummynet pipe.

	cheers
	luigi

> -- 
> 
> John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
> "Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/