From owner-freebsd-stable@FreeBSD.ORG Sat Sep 18 06:04:17 2010 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B7CAB106566C for ; Sat, 18 Sep 2010 06:04:17 +0000 (UTC) (envelope-from jdc@koitsu.dyndns.org) Received: from qmta08.emeryville.ca.mail.comcast.net (qmta08.emeryville.ca.mail.comcast.net [76.96.30.80]) by mx1.freebsd.org (Postfix) with ESMTP id 9B43B8FC1A for ; Sat, 18 Sep 2010 06:04:17 +0000 (UTC) Received: from omta11.emeryville.ca.mail.comcast.net ([76.96.30.36]) by qmta08.emeryville.ca.mail.comcast.net with comcast id 85xu1f0040mlR8UA864HJN; Sat, 18 Sep 2010 06:04:17 +0000 Received: from koitsu.dyndns.org ([98.248.41.155]) by omta11.emeryville.ca.mail.comcast.net with comcast id 864F1f0053LrwQ28X64F84; Sat, 18 Sep 2010 06:04:16 +0000 Received: by icarus.home.lan (Postfix, from userid 1000) id 412959B427; Fri, 17 Sep 2010 23:04:15 -0700 (PDT) Date: Fri, 17 Sep 2010 23:04:15 -0700 From: Jeremy Chadwick To: Paul Mather Message-ID: <20100918060415.GA72689@icarus.home.lan> References: <201009152007.17320.Pascal.Stumpf@cubes.de> <201009151830.o8FIUWEZ021844@lava.sentex.ca> <4C911AB0.6090901@delphij.net> <4C91AEBF.50502@FreeBSD.org> <4CD27341-4430-4739-93C2-EEAD93A1866F@gromit.dlib.vt.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4CD27341-4430-4739-93C2-EEAD93A1866F@gromit.dlib.vt.edu> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: d@delphij.net, Pascal Stumpf , Xin LI , Martin Matuska , stable@FreeBSD.org Subject: Re: MFC of ZFSv15 X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 18 Sep 2010 06:04:17 -0000 On Fri, Sep 17, 2010 at 08:37:50AM -0400, Paul Mather wrote: > On Sep 16, 2010, at 1:44 AM, Martin Matuska wrote: > > > I have fixed the missing bits in r212688. > > > > Thanks for the notice. > > > > Dňa 15. 9. 2010 21:12, Xin LI wrote / napísal(a): > >> On 2010/09/15 11:30, Mike Tancsa wrote: > >>> At 02:07 PM 9/15/2010, Pascal Stumpf wrote: > >>>> First of all, a great thanks to mm@ and pjd@ for the excellent work on > >>>> ZFS in FreeBSD. :) And especially for the MFC of v15 a few hours ago. > >> > >> [...] > >>> here too. RELENG_8 AMD64. The tinderboxes havent hit that branch yet > >>> (http://tinderbox.freebsd.org/), so it > >>> will be a few hrs before they get to test RELENG_8 > >> [...] > >>> -lsbuf -lm -lnvpair -luutil -lutil > >>> /usr/obj/usr/src/tmp/usr/lib/libzfs.so: undefined reference to `getmntent' > >>> *** Error code 1 > >> > >> Sorry for that, it seems to be caused by a partial merge > >> (cddl/compat/opensolaris/misc/mnttab.c). mm@ is going to fix that ASAP. > >> > >> Cheers, > > I am getting a build failure on 8.1-STABLE: > > ===== > [[...]] > cc -c -O2 -pipe -fno-strict-aliasing -march=pentium4 -std=c99 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -fstack-protector -Werror /usr/src/sys/kern/p1003_1b.c > cc -c -O2 -pipe -fno-strict-aliasing -march=pentium4 -std=c99 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -fstack-protector -Werror /usr/src/sys/kern/posix4_mib.c > cc -c -O2 -pipe -fno-strict-aliasing -march=pentium4 -std=c99 -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef -Wno-pointer-sign -fformat-extensions -nostdinc -I. -I/usr/src/sys -I/usr/src/sys/contrib/altq -D_KERNEL -DHAVE_KERNEL_OPTION_HEADERS -include opt_global.h -fno-common -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -mno-align-long-strings -mpreferred-stack-boundary=2 -mno-mmx -mno-3dnow -mno-sse -mno-sse2 -mno-sse3 -ffreestanding -fstack-protector -Werror /usr/src/sys/kern/sched_ule.c > cc1: warnings being treated as errors > /usr/src/sys/kern/sched_ule.c: In function 'sched_switch': > /usr/src/sys/kern/sched_ule.c:1807: warning: implicit declaration of function 'sched_pickcpu' > /usr/src/sys/kern/sched_ule.c:1807: warning: nested extern declaration of 'sched_pickcpu' > *** Error code 1 The problem was that a piece of committed code in the ULE scheduler was lacking an #ifdef statement for checking "options SMP". Meaning: kernel configs which lacked "options SMP" would break exactly as shown above. This has been fixed (see "Fix UP build" commit); please update your source tree. http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/kern/sched_ule.c -- | Jeremy Chadwick jdc@parodius.com | | Parodius Networking http://www.parodius.com/ | | UNIX Systems Administrator Mountain View, CA, USA | | Making life hard for others since 1977. PGP: 4BD6C0CB |