From owner-svn-src-head@freebsd.org  Wed Jul 15 07:32:20 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id A3F409A21B5;
 Wed, 15 Jul 2015 07:32:20 +0000 (UTC)
 (envelope-from julian@freebsd.org)
Received: from vps1.elischer.org (vps1.elischer.org [204.109.63.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "vps1.elischer.org",
 Issuer "CA Cert Signing Authority" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id 7A4AB1BFA;
 Wed, 15 Jul 2015 07:32:20 +0000 (UTC)
 (envelope-from julian@freebsd.org)
Received: from Julian-MBP3.local (ppp121-45-240-47.lns20.per4.internode.on.net
 [121.45.240.47]) (authenticated bits=0)
 by vps1.elischer.org (8.14.9/8.14.9) with ESMTP id t6F7WDKk079032
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);
 Wed, 15 Jul 2015 00:32:16 -0700 (PDT)
 (envelope-from julian@freebsd.org)
Message-ID: <55A60C78.7050808@freebsd.org>
Date: Wed, 15 Jul 2015 15:32:08 +0800
From: Julian Elischer <julian@freebsd.org>
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10;
 rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: d@delphij.net, Ian Lepore <ian@freebsd.org>
CC: Garrett Cooper <yaneurabeya@gmail.com>,
 Baptiste Daroussin <bapt@FreeBSD.org>,
 src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r285552 - head/usr.bin/xargs
References: <201507141916.t6EJGEG1083928@repo.freebsd.org>	
 <48222CD1-7087-4C9A-A586-71F6A37A601C@gmail.com>	
 <55A574BA.4090700@delphij.net> <1436912270.1334.309.camel@freebsd.org>
 <55A5A30F.4070005@delphij.net>
In-Reply-To: <55A5A30F.4070005@delphij.net>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 15 Jul 2015 07:32:20 -0000

On 7/15/15 8:02 AM, Xin Li wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA512
>
> On 07/14/15 15:17, Ian Lepore wrote:
>> On Tue, 2015-07-14 at 13:44 -0700, Xin Li wrote:
>>> On 07/14/15 13:29, Garrett Cooper wrote:
>>>> On Jul 14, 2015, at 12:16, Baptiste Daroussin
>>>> <bapt@FreeBSD.org> wrote:
>>>>
>>>>> Author: bapt Date: Tue Jul 14 19:16:14 2015 New Revision:
>>>>> 285552 URL: https://svnweb.freebsd.org/changeset/base/285552
>>>>>
>>>>> Log: Convert atoi(3) to stronum(3) which allows to arguments
>>>>> and report proper errors to the users
>>>> Is strtonum preferred over strtoll, etc?
>>> strtonum(3) is a wrapper of strtoll() and provides more
>>> functionality like range checking, so I think the answer would be
>>> yes.
>>>
>>> Cheers,
>>>
>> Except if we convert all our tools that take numbers on the command
>> line to use strtonum() then peoples' existing scripts and other
>> automation that passes 0xWhatever numbers suddenly stop working.
>> strtonum() seems to be about 2/3 of a good idea.
> I think the caller has to be calling with 0 or 16 as base to request
> that behavior?  If we are converting from atoi, the base number is a
> fixed value of 10.
>
> My only concern with strtonum() is that it's English only.
does it cover 0100 and 0x100?