From owner-freebsd-wireless@freebsd.org Mon May 4 20:08:55 2020 Return-Path: Delivered-To: freebsd-wireless@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7E5C32C19C0; Mon, 4 May 2020 20:08:55 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-qk1-f194.google.com (mail-qk1-f194.google.com [209.85.222.194]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49GDT24tnjz3Fff; Mon, 4 May 2020 20:08:54 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: by mail-qk1-f194.google.com with SMTP id b6so886898qkh.11; Mon, 04 May 2020 13:08:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=ILxGCw83dGaFy48T2ccrEhVTHH2QXX0Zu6q3y6byNrc=; b=QdXFXnMZerWXuZOo9IaTNnL6n3SbQ2f/mM9qrBGHkOXgpcnMO7h27XDG4GxckS/hrs aux2CBOteicqtxG3p1gs5BhbEN3/PiC1Y/lyb4TTrDfrI39vsoqRTbZeiPnbiD0ZvjRn 5GlC+4IDE51t1OEGl6tujhOf5f4K81c2rGbW32zn91TSd9n0djyowVHsbYO6V8V4zB2g qYCl/AKZvwu92Cje8/DokvtsTaUsq5ZVbKLbY6Pn5EeQHqslq4CBeH/prXds7WVaPX79 zi3VaIm5e8pXxzmz+fcBscFAeydpT798hCLyOzcg1u/iyoBrPAyNzXr0QsYd4t9EpjrI dDhA== X-Gm-Message-State: AGi0PuY1q7ivrgR6RltigBWyZmBT7uRHn4sHNSYnX5BwrzvmpvVLT62t /Inb2CDjKKs3QbJeZIscZR30bSiesGme/xhzVF9bu56l X-Google-Smtp-Source: APiQypLBJmEYIFlttTflpichMKox2aWL0ANr5xIY+hYstDNCRPEz+2Dsf5E65P992XglaWx5CLPzs0N0rGNMGfSQj8M= X-Received: by 2002:a05:620a:7e8:: with SMTP id k8mr45999qkk.183.1588622932502; Mon, 04 May 2020 13:08:52 -0700 (PDT) MIME-Version: 1.0 References: <201912212101.xBLL14sr033938@repo.freebsd.org> In-Reply-To: From: Adrian Chadd Date: Mon, 4 May 2020 13:08:40 -0700 Message-ID: Subject: Re: svn commit: r355988 - in head: contrib/libpcap contrib/libpcap/cmake/Modules contrib/libpcap/doc contrib/libpcap/missing contrib/libpcap/msdos contrib/libpcap/pcap contrib/libpcap/rpcapd contrib/li... To: Cy Schubert , "freebsd-mips@freebsd.org" , freebsd-wireless Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 49GDT24tnjz3Fff X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of adrianchadd@gmail.com designates 209.85.222.194 as permitted sender) smtp.mailfrom=adrianchadd@gmail.com X-Spamd-Result: default: False [-2.17 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; MIME_TRACE(0.00)[0:+]; DMARC_NA(0.00)[freebsd.org]; TO_DN_SOME(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; IP_SCORE(-0.18)[ip: (-0.01), ipnet: 209.85.128.0/17(-0.40), asn: 15169(-0.43), country: US(-0.05)]; RCVD_IN_DNSWL_NONE(0.00)[194.222.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-0.99)[-0.993,0]; FORGED_SENDER(0.30)[adrian@freebsd.org,adrianchadd@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[194.222.85.209.rep.mailspike.net : 127.0.0.17]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[adrian@freebsd.org,adrianchadd@gmail.com]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2020 20:08:55 -0000 On Mon, 4 May 2020 at 12:54, Adrian Chadd wrote: > > hi, > > This commit /seems/ to have broken things on FreeBSD-HEAD on mips74k. > I haven't yet tried hostapd mode on x86 with this commit; I"ll do that > soon. > > The TL;DR: > > * hostapd + wpa encryption + mips32 (mips74k in this instance) fails > on -HEAD! Woo! > > * l2_packet_freebsd.c in hostapd uses a pcap filter to filter out > eapol frames from other parties to the eapol/raw receive socket; > * the filter compilation causes an unaligned access on mips, which i > /thought/ we handled correctly, but apparently not; > * the filter as written in hostapd doesn't result in anything being received. > > The unaligned warn is: > > Unaligned Load Word: pid=426 (tcpdump), tid=100040, pc=0x40569034, > badvaddr=0x4051d02a > > (I dno't yet have the line of code, that's next too.) > > The filter is: > > *** Filter is "not ether src c4:6e:1f:5b:04:f7 and ( ether dst > c4:6e:1f:5b:04:f7 or ether dst 01:80:c2:00:00:03 ) and ether proto > 0x888e" > > I'll dig into the details some more soon. > Here's an example EAPOL exchange with a minimal filter: # tcpdump -l -ni wlan0 -y IEEE802_11_RADIO -vvvv -eeee "(ether proto 0x888e)" tcpdump: data link type IEEE802_11_RADIO tcpdump: listening on wlan0, link-type IEEE802_11_RADIO (802.11 plus radiotap header), capture size 262144 bytes 19:58:39.880399 1.0 Mb/s 60dBm tx power antenna 0 2412 MHz 11g ht/20 0us DA:00:03:7f:40:82:1a BSSID:c4:6e:1f:5b:04:f7 SA:c4:6e:1f:5b:04:f7 LLC, dsap SNAP (0xaa) Individual, ssap SNAP (0xaa) Command, ctrl 0x03: oui Ethernet (0x000000), ethertype EAPOL (0x888e), length 99: EAPOL key (3) v2, len 95 19:58:39.885193 846271791us tsft 1.0 Mb/s -29dBm signal -96dBm noise antenna 1 2412 MHz 11g 314us BSSID:c4:6e:1f:5b:04:f7 SA:00:03:7f:40:82:1a DA:c4:6e:1f:5b:04:f7 LLC, dsap SNAP (0xaa) Individual, ssap SNAP (0xaa) Command, ctrl 0x03: oui Ethernet (0x000000), ethertype EAPOL (0x888e), length 121: EAPOL key (3) v1, len 117 19:58:39.886907 1.0 Mb/s 60dBm tx power antenna 0 2412 MHz 11g ht/20 0us DA:00:03:7f:40:82:1a BSSID:c4:6e:1f:5b:04:f7 SA:c4:6e:1f:5b:04:f7 LLC, dsap SNAP (0xaa) Individual, ssap SNAP (0xaa) Command, ctrl 0x03: oui Ethernet (0x000000), ethertype EAPOL (0x888e), length 203: EAPOL key (3) v2, len 199 19:58:39.892254 846278862us tsft 1.0 Mb/s -32dBm signal -96dBm noise antenna 1 2412 MHz 11g 314us BSSID:c4:6e:1f:5b:04:f7 SA:00:03:7f:40:82:1a DA:c4:6e:1f:5b:04:f7 LLC, dsap SNAP (0xaa) Individual, ssap SNAP (0xaa) Command, ctrl 0x03: oui Ethernet (0x000000), ethertype EAPOL (0x888e), length 99: EAPOL key (3) v1, len 95 Note it's between 00:03:7f:40:82:1a (the STA) and c4:6e:1f:5b:04:f7 (the AP). If I add the ether dst clause - either half - I get nothing. Any ideas? :) I can chop the filter down to EAPOL only for now to save on AP CPU but I'd love to get to the root cause and fix it in -HEAD and -12. Thanks! -adrian > Thanks, > > > > -adrian > > > On Sat, 21 Dec 2019 at 13:01, Cy Schubert wrote: > > > > Author: cy > > Date: Sat Dec 21 21:01:03 2019 > > New Revision: 355988 > > URL: https://svnweb.freebsd.org/changeset/base/355988 > > > > Log: > > MFV r353141 (by phillip): > > > > Update libpcap from 1.9.0 to 1.9.1. > > > > MFC after: 2 weeks