From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Oct 29 08:59:12 2012 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 67864383; Mon, 29 Oct 2012 08:59:12 +0000 (UTC) (envelope-from cpetservice@gmail.com) Received: from mail-qa0-f47.google.com (mail-qa0-f47.google.com [209.85.216.47]) by mx1.freebsd.org (Postfix) with ESMTP id EEAC98FC18; Mon, 29 Oct 2012 08:59:11 +0000 (UTC) Received: by mail-qa0-f47.google.com with SMTP id i29so1583267qaf.13 for ; Mon, 29 Oct 2012 01:59:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=ZMfZHNW05Ip4L739ZxVi1TQNlk3XVGUyPE6TOk1Hojg=; b=CaXn6gEvIqWn3LoAmK3tWFPcu5hGeleIoXrmSyBsdYTMQ+SC3zKcMe/D8GQRmqIcbv gzZNeAelY1IOOEan+5N9sdrz+3F5+GxzvqRVGSp2CZN73FZ+JDSJKrHe1dXqq4OZwQXV AlfkLuA7YKbheclh9+BQb9IjYYKDoq/q2nlKbh/Pj4oJIHiBj3XCpPClBCdqC3XF2S6F ScPjmoNWhJyWfkwWSx6zkHHenQhfOUY1Qo77K/A/HDAXaoNgqCnc+xJqb5fWX2DuBWRZ AhMm86Eu2Gq1FZft9SYvl1oj00ne/6Wzzz85a7ZsJ9D5Rx5HOb+Es0QTxVF7En8/IGRn 2cSg== MIME-Version: 1.0 Received: by 10.224.117.20 with SMTP id o20mr14514671qaq.12.1351501150360; Mon, 29 Oct 2012 01:59:10 -0700 (PDT) Received: by 10.49.104.197 with HTTP; Mon, 29 Oct 2012 01:59:10 -0700 (PDT) Received: by 10.49.104.197 with HTTP; Mon, 29 Oct 2012 01:59:10 -0700 (PDT) In-Reply-To: <201210290830.q9T8U1Vp095785@freefall.freebsd.org> References: <201210290830.q9T8U1Vp095785@freefall.freebsd.org> Date: Mon, 29 Oct 2012 02:59:10 -0600 Message-ID: Subject: Re: ports/172976: fix for bugged patch in devel/flyspray 0.9.9.7 From: Cpet Services To: Raphael Kubo da Costa Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: freebsd-ports-bugs@freebsd.org X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2012 08:59:12 -0000 The patch supplied should really be used. Converting dos 2 unix should not have any real issues. As well options ng conversion which would need to be done anyways. The patch is such a small change that a simple reinplace should be enough Patch can be found here http://cpet.multics.org/patches/ports/patch-flyspray.txt On Oct 29, 2012 2:30 AM, "Raphael Kubo da Costa" wrote: > The following reply was made to PR ports/172976; it has been noted by > GNATS. > > From: Raphael Kubo da Costa > To: Nick Hilliard > Cc: Cpet Services , bug-followup@FreeBSD.org > Subject: Re: ports/172976: fix for bugged patch in devel/flyspray 0.9.9.7 > Date: Mon, 29 Oct 2012 06:27:56 -0200 > > Nick Hilliard writes: > > > On 29/10/2012 00:04, Cpet Services wrote: > >> Using this: > >> > >> + @${REINPLACE_CMD} "s|E_ALL|E_ALL \& ~E_STRICT|g" \ > >> + ${WRKSRC}/includes/fix.inc.php > >> > >> As well as: > >> > >> +USE_DOS2UNIX= yes > >> > >> +DOS2UNIX_REGEX= .php > >> > >> You can remove the patch entirely > > > > I think this is a better approach than messing around with svn eol > > properties - thanks Chris. > > This will end up patching all PHP source files; if you're fine with > this, please file a new PR with a patch (preferrably CC'ing me) and I > can commit it. > _______________________________________________ > freebsd-ports-bugs@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs > To unsubscribe, send any mail to " > freebsd-ports-bugs-unsubscribe@freebsd.org" >