From owner-svn-src-head@freebsd.org Wed Jan 4 21:45:55 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 89DC9C9F125; Wed, 4 Jan 2017 21:45:55 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "tensor.andric.com", Issuer "COMODO RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 523C812D8; Wed, 4 Jan 2017 21:45:55 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from [IPv6:2001:7b8:3a7::edbb:2c55:e474:cdd2] (unknown [IPv6:2001:7b8:3a7:0:edbb:2c55:e474:cdd2]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id B4DE936CFF; Wed, 4 Jan 2017 22:45:51 +0100 (CET) Content-Type: multipart/signed; boundary="Apple-Mail=_DCD0AA8A-28DA-48C7-B47E-9FB9FD16D771"; protocol="application/pgp-signature"; micalg=pgp-sha1 Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Subject: Re: svn commit: r310889 - head/tools/build/mk From: Dimitry Andric In-Reply-To: <201612310607.uBV67mVO019147@repo.freebsd.org> Date: Wed, 4 Jan 2017 22:45:46 +0100 Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: References: <201612310607.uBV67mVO019147@repo.freebsd.org> To: Jung-uk Kim X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 Jan 2017 21:45:55 -0000 --Apple-Mail=_DCD0AA8A-28DA-48C7-B47E-9FB9FD16D771 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On 31 Dec 2016, at 07:07, Jung-uk Kim wrote: >=20 > Author: jkim > Date: Sat Dec 31 06:07:48 2016 > New Revision: 310889 > URL: https://svnweb.freebsd.org/changeset/base/310889 >=20 > Log: > Do not remove llvm-objdump. It is installed by default since = r310840. >=20 > Modified: > head/tools/build/mk/OptionalObsoleteFiles.inc >=20 > Modified: head/tools/build/mk/OptionalObsoleteFiles.inc > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/tools/build/mk/OptionalObsoleteFiles.inc Sat Dec 31 = 03:07:48 2016 (r310888) > +++ head/tools/build/mk/OptionalObsoleteFiles.inc Sat Dec 31 = 06:07:48 2016 (r310889) > @@ -1484,7 +1484,6 @@ OLD_FILES+=3Dusr/bin/llvm-link > OLD_FILES+=3Dusr/bin/llvm-lto > OLD_FILES+=3Dusr/bin/llvm-mc > OLD_FILES+=3Dusr/bin/llvm-nm > -OLD_FILES+=3Dusr/bin/llvm-objdump > OLD_FILES+=3Dusr/bin/llvm-pdbdump > OLD_FILES+=3Dusr/bin/llvm-rtdyld > OLD_FILES+=3Dusr/bin/llvm-symbolizer This block is under MK_CLANG_EXTRAS. Shouldn't llvm-objdump be moved to the MK_CLANG block just above instead? Otherwise it would never be cleaned up, if somebody disabled llvm/clang completely. -Dimitry --Apple-Mail=_DCD0AA8A-28DA-48C7-B47E-9FB9FD16D771 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.30 iEYEARECAAYFAlhtbQ8ACgkQsF6jCi4glqOX/wCg/xD3xzlHp2MoLgz4xRBnpG6i SBMAniJMa1gmVN20FuK95RW25Pm6e2sO =vRhu -----END PGP SIGNATURE----- --Apple-Mail=_DCD0AA8A-28DA-48C7-B47E-9FB9FD16D771--