From owner-cvs-all@FreeBSD.ORG Wed Jun 15 00:56:16 2011 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 49FC61065670; Wed, 15 Jun 2011 00:56:16 +0000 (UTC) (envelope-from takefu@airport.fm) Received: from ae-osaka.co.jp (unknown [IPv6:2001:3e0:4ec:a000::1]) by mx1.freebsd.org (Postfix) with ESMTP id D2D338FC14; Wed, 15 Jun 2011 00:56:15 +0000 (UTC) Received: from ae-osaka.co.jp (localhost.ae-osaka.co.jp [127.0.0.1]) by ae-osaka.co.jp (Postfix) with ESMTP id 1932111456; Wed, 15 Jun 2011 09:56:14 +0900 (JST) X-Virus-Scanned: amavisd-new at ae-osaka.co.jp Received: from ae-osaka.co.jp ([127.0.0.1]) by ae-osaka.co.jp (ae-osaka.co.jp [127.0.0.1]) (amavisd-new, port 10024) with LMTP id IlGK0nNWm4Ue; Wed, 15 Jun 2011 09:56:13 +0900 (JST) Received: from [IPv6:2001:3e0:4ec:a011:a980:700c:a4cb:fc6] (unknown [IPv6:2001:3e0:4ec:a011:a980:700c:a4cb:fc6]) by ae-osaka.co.jp (Postfix) with ESMTPSA id 60CE11144D; Wed, 15 Jun 2011 09:56:13 +0900 (JST) Message-ID: <4DF8033E.7020003@airport.fm> Date: Wed, 15 Jun 2011 09:56:30 +0900 From: Takefu User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; ja; rv:1.9.2.17) Gecko/20110414 Thunderbird/3.1.10 MIME-Version: 1.0 To: Andrej Zverev References: <201106141516.p5EFGaGY095553@repoman.freebsd.org> In-Reply-To: X-Enigmail-Version: 1.1.1 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Cc: Frederic Culot , ports-committers@freebsd.org, cvs-all@freebsd.org, cvs-ports@freebsd.org Subject: Re: cvs commit: ports/www/p5-HTML-Defaultify Makefile X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2011 00:56:16 -0000 Hi. 2)a) It agrees with this change. Other reviews listed above is not a negative. Not too positive. Andrej Zverev さんは書きました (2011/06/15 1:44): > Hello. > I would like to suggest following patch. > 1) More preferable to depend on CPAN infrastructure less on private author > sites. > 2) Fix pkg-descr: > a) Description text from module > b) WWW: to CPAN (we prefer this I hope and it contrain full module > documentaion). > 3) Some Makefile rearrangement. > > Patch: http://sunner.semmy.ru/~az/patches/p5-HTML-Defaultify.diff.txt --- p5-HTML-Defaultify.patch begins here --- diff -ruN /usr/ports/www/p5-HTML-Defaultify/Makefile www/p5-HTML-Defaultify/Makefile --- /usr/ports/www/p5-HTML-Defaultify/Makefile 2011-06-15 09:18:52.000000000 +0900 +++ www/p5-HTML-Defaultify/Makefile 2011-06-15 09:23:36.000000000 +0900 @@ -15,12 +15,9 @@ MAINTAINER= takefu@airport.fm COMMENT= Perl module to populate HTML forms with default values -PERL_CONFIGURE= yes +RUN_DEPENDS= p5-HTML-Parser>=0:${PORTSDIR}/www/p5-HTML-Parser +PERL_CONFIGURE= yes MAN3= HTML::Defaultify.3 -.include - -RUN_DEPENDS+= p5-HTML-Parser>=0:${PORTSDIR}/www/p5-HTML-Parser - -.include +.include diff -ruN /usr/ports/www/p5-HTML-Defaultify/pkg-descr www/p5-HTML-Defaultify/pkg-descr --- /usr/ports/www/p5-HTML-Defaultify/pkg-descr 2011-03-04 22:58:35.000000000 +0900 +++ www/p5-HTML-Defaultify/pkg-descr 2011-06-15 09:48:10.000000000 +0900 @@ -1,3 +1,10 @@ -HTML::Defaultify - Pre-fill default values into an existing HTML form +This module lets you take an existing HTML page with forms in it, and fill in +the form fields according to defaults you give. It's most useful in CGI +scripts. One common use is to handle invalid user input-- show them the same +form with their previously entered values filled in, and let them correct any +errors. Another use might be when letting users edit a database record, such as +their account information-- show them an input form with the current values +filled in. There are other uses. WWW: http://www.jmarshall.com/tools/defaultify/ + http://search.cpan.org/dist/HTML-Defaultify/ --- p5-HTML-Defaultify.patch ends here ---