Date: Mon, 2 Nov 2015 14:38:45 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Andriy Voskoboinyk <avos@freebsd.org>, "freebsd-wireless@freebsd.org" <freebsd-wireless@freebsd.org> Subject: Re: bridge/wifi panic Message-ID: <CAJ-Vmo=LgSeD%2BViEYdp4D2kBqQ=1KNOSnTTke9SqzkgJLtEHaw@mail.gmail.com> In-Reply-To: <CAJ-Vmo=tc%2BHvcLAVe_APVFkLUs76SmhpYJiPZT7BAyL5Jin-EQ@mail.gmail.com> References: <1446174922.809135.424262409.16BCE412@webmail.messagingengine.com> <CAJ-Vmon-kwdeG2nVRGMoKBE654o0Yx8G8UB9=E6%2Ba=XyvDNrmg@mail.gmail.com> <BEB3A1D6-B877-4C65-B66E-9EFA39E2912C@FreeBSD.org> <CAJ-Vmo=exW_kmX0tnjQ81o8HxgJvG=5KtWf%2B3cQeAFteLPgtHw@mail.gmail.com> <A6634DC8-90CB-40C1-8B93-747E6AAC4A3D@FreeBSD.org> <CAJ-VmonrCfB_6jvFLMrJ6fD4ma=f8mHNmhQhum86wOPmzTNdoA@mail.gmail.com> <1446474203.3014685.426732569.13D78488@webmail.messagingengine.com> <CAJ-VmokBbh6Uh6FOaKhKPH_FxbNcHu7EdxP1SSh1ZzeQKqda_Q@mail.gmail.com> <op.x7hcb1o54dikkl@localhost> <CAJ-Vmo=uZbErxRudyoq6B7AG=SRb_PmoTQ4cD8-uhVPFHzbOEQ@mail.gmail.com> <CAJ-Vmo=tc%2BHvcLAVe_APVFkLUs76SmhpYJiPZT7BAyL5Jin-EQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Actually, this is more annoying than I'd thought. There's a whole bunch of places where mbufs can change during processing in ath(4) and yeah, we can't guarantee the original mbuf is available. I wonder how many other drivers are doing this - stuff like m_collapse(), m_defrag(), etc. If this is called then the original mbuf can't be returned upon error. I'm torn as to whether to back out the mbuf API change and have the driver consume it, or whether we want to go through the pain of fixing things. Let's figure this out ASAP. Thanks, -adrian On 2 November 2015 at 14:35, Adrian Chadd <adrian@freebsd.org> wrote: > Ok, yeah, I think your initial churn of ath(4) for error handling is > way incomplete, and we're going to have to fix this stuff before it > causes lots more issues in -HEAD. > > > > -a
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmo=LgSeD%2BViEYdp4D2kBqQ=1KNOSnTTke9SqzkgJLtEHaw>