From owner-freebsd-current@FreeBSD.ORG Fri Dec 30 13:43:40 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0FF2E106566B; Fri, 30 Dec 2011 13:43:40 +0000 (UTC) (envelope-from tijl@coosemans.org) Received: from mailrelay009.isp.belgacom.be (mailrelay009.isp.belgacom.be [195.238.6.176]) by mx1.freebsd.org (Postfix) with ESMTP id 5C92D8FC17; Fri, 30 Dec 2011 13:43:38 +0000 (UTC) X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0EAB+4/U5bsQ3b/2dsb2JhbABDrE6BBoFyAQEFJy8jEAsYLjkeGYd8thaDfYR4gxoEiASGIpkR Received: from 219.13-177-91.adsl-dyn.isp.belgacom.be (HELO kalimero.tijl.coosemans.org) ([91.177.13.219]) by relay.skynet.be with ESMTP; 30 Dec 2011 14:13:36 +0100 Received: from kalimero.tijl.coosemans.org (kalimero.tijl.coosemans.org [127.0.0.1]) by kalimero.tijl.coosemans.org (8.14.5/8.14.5) with ESMTP id pBUDDZ24001806; Fri, 30 Dec 2011 14:13:35 +0100 (CET) (envelope-from tijl@coosemans.org) From: Tijl Coosemans To: freebsd-current@freebsd.org Date: Fri, 30 Dec 2011 14:13:25 +0100 User-Agent: KMail/1.13.7 (FreeBSD/10.0-CURRENT; KDE/4.7.3; i386; ; ) References: <4EFC0127.6030301@FreeBSD.org> <4EFC5487.3080709@orange.fr> In-Reply-To: <4EFC5487.3080709@orange.fr> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6025371.nWztoTEdQX"; protocol="application/pgp-signature"; micalg=pgp-sha256 Content-Transfer-Encoding: 7bit Message-Id: <201112301413.32750.tijl@coosemans.org> Cc: "Joseph S. Atkinson" , Alexander Motin Subject: Re: CD Access in 9.x and -CURRENT X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 30 Dec 2011 13:43:40 -0000 --nextPart6025371.nWztoTEdQX Content-Type: multipart/mixed; boundary="Boundary-01=_2jb/ONakLCsTfGs" Content-Transfer-Encoding: 7bit --Boundary-01=_2jb/ONakLCsTfGs Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Thursday 29 December 2011 12:52:39 Claude Buisson wrote: > On 12/29/2011 07:41, Garrett Cooper wrote: >> On Wed, Dec 28, 2011 at 9:56 PM, Joseph S. Atkinson wr= ote: >>> I am the maintainer of VLC, I have an outstanding PR (ports/162190) on = the >>> issue of cdda:// access. >>> >>> I can confirm this issues, but don't know enough about driver access to= fix >>> this myself. Doug Barton reports that cdcontrol(1) doesn't work for him= , and >>> mplayer and audactiy also display issues running as non-root. >>> >>> Under 9.0-RC3 r228843, I get these errors on boot with no disc present = in >>> /dev/cd0 at all. >>> >>> (pass1:ahcich2:0:0:0): ATA_IDENTIFY. ACB: ec 00 00 00 00 40 00 00 00 00= 01 >>> 00 >>> (pass1:ahcich2:0:0:0): CAM status: ATA Status Error >>> (pass1:ahcich2:0:0:0): ATA status: 51 (DRDY SERV ERR), error: 04 (ABRT ) >>> (pass1:ahcich2:0:0:0): RES: 51 04 01 14 eb 40 00 00 00 01 00 >>> >>> These ports are fairly popular, but the problems may not lie exclusively >>> with their assumptions about FreeBSD. I am running 10.0 on another mach= ine >>> specifically to test changes under src/sys/cam. >>> >>> I am worried that with the actual 9.0-RELEASE on the horizon, users will >>> find show stopping problems using their disc drives. >> >> Try having users merge r228808 and r228847. If that works, then I >> would press re@ produce another RC that fixes this. >> Thanks, >> -Garrett >> >> PS This is coming from a user that was annoyed by this gap with the >> ATA_CAM code. >=20 > As the submitter of ports/162190, I would firstly ask: >=20 > Is the problem corrected by r228808 and r228847 in 10.0-CURRENT ? >=20 > If not merging to 9.0 is useless. >=20 > If yes I could test. There are 3 methods to access audio CDs. =2D if your drive is connected to your sound card you can use the drive's built-in audio support (if present). (used by cdcontrol) =2D read raw audio data via the CAM layer. (used by cdparanoia) =2D read raw audio data via the cd(4) driver. (used by vlc, libcdio?) The first two should work. The last one has now been fixed in CURRENT, but programs using that method also seem to use CDRIOCSETBLOCKSIZE ioctl that cd doesn't implement. The driver already knows the correct block size though, so it seems safe to ignore the error. With the attached patch vlc works for me. --Boundary-01=_2jb/ONakLCsTfGs Content-Type: text/plain; charset="iso-8859-1"; name="patch-modules__access__vcd__cdrom.c" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="patch-modules__access__vcd__cdrom.c" =2D-- modules/access/vcd/cdrom.c.orig +++ modules/access/vcd/cdrom.c @@ -553,9 +553,6 @@ if( ioctl( p_vcddev->i_device_handle, CDRIOCSETBLOCKSIZE, &i_size ) =3D=3D -1 ) { =2D msg_Err( p_this, "Could not set block size" ); =2D if( i_type =3D=3D VCD_TYPE ) free( p_block ); =2D return( -1 ); } =20 if( lseek( p_vcddev->i_device_handle, --Boundary-01=_2jb/ONakLCsTfGs-- --nextPart6025371.nWztoTEdQX Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.18 (FreeBSD) iF4EABEIAAYFAk79uPwACgkQfoCS2CCgtiuDnQD9GzveJJ0ciCHqUjlwEKFhNrTj uVFbkipqZ831iu9v4vgA/A/SqAZQhCayrbJkXV56g0jLWtQEYBn3Tpber0mGH01r =yETJ -----END PGP SIGNATURE----- --nextPart6025371.nWztoTEdQX--