From owner-cvs-src@FreeBSD.ORG  Fri Mar  7 14:19:06 2008
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 36AAA1065672;
	Fri,  7 Mar 2008 14:19:06 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.freebsd.org (Postfix) with ESMTP id 1D0C28FC17;
	Fri,  7 Mar 2008 14:19:05 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from zion.baldwin.cx (66-23-211-162.clients.speedfactory.net
	[66.23.211.162]) by elvis.mu.org (Postfix) with ESMTP id 69A451A4D84;
	Fri,  7 Mar 2008 06:18:35 -0800 (PST)
From: John Baldwin <jhb@freebsd.org>
To: Marcel Moolenaar <marcel@freebsd.org>
Date: Fri, 7 Mar 2008 08:01:30 -0500
User-Agent: KMail/1.9.7
References: <200803061724.m26HOSPO026401@repoman.freebsd.org>
In-Reply-To: <200803061724.m26HOSPO026401@repoman.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200803070801.30460.jhb@freebsd.org>
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/sys pcpu.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Mar 2008 14:19:06 -0000

On Thursday 06 March 2008 12:24:28 pm Marcel Moolenaar wrote:
> marcel      2008-03-06 17:24:28 UTC
>
>   FreeBSD src repository
>
>   Modified files:
>     sys/sys              pcpu.h
>   Log:
>   Move the PCPU_MD_FIELDS last in struct pcpu. While this header is
>   private to the kernel, some ports define _KERNEL and include this
>   header. While arguably this is wrong, it's also reality. By having
>   the MD fields last, architectures that have CPU-specific variations
>   of PCPU_MD_FIELDS will at least have the MI fields at a constant
>   offset.  Of course, having all MI fields first helps kernel debugging
>   as well, so this is not a change without some benefits to us.
>
>   This change does not result in an ABI breakage, because this header
>   is not part of the ABI. Recompilation of lsof is required though :-)

It actually started out being the last "field" in the structure but some new 
fields were incorrectly added after it rather than before it.  It might 
warrant a comment to prevent similar regressions in the future.

-- 
John Baldwin