Date: Mon, 9 Jun 2008 18:32:48 -0700 From: "Garrett Cooper" <yanegomi@gmail.com> To: "Anders Nore" <andenore@freebsd.org> Cc: Perforce Change Reviews <perforce@freebsd.org> Subject: Re: PERFORCE change 143220 for review Message-ID: <364299f40806091832g72ccee5ap462e698aea723f3b@mail.gmail.com> In-Reply-To: <200806092250.m59Mog8G052587@repoman.freebsd.org> References: <200806092250.m59Mog8G052587@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jun 9, 2008 at 3:50 PM, Anders Nore <andenore@freebsd.org> wrote: > http://perforce.freebsd.org/chv.cgi?CH=143220 > > Change 143220 by andenore@andenore_laptop on 2008/06/09 22:49:41 > > Added the indexing of 'which' functionality in converter, and > pkg_info -W uses this index if cache is available, huge performance > boost compared to the old method. > > Affected files ... > > .. > //depot/projects/soc2008/andenore_pkginstall/src/usr.sbin/pkg_install/convert/converter.c#2 > edit > .. > //depot/projects/soc2008/andenore_pkginstall/src/usr.sbin/pkg_install/info/main.c#3 > edit > .. > //depot/projects/soc2008/andenore_pkginstall/src/usr.sbin/pkg_install/info/perform.c#3 > edit > .. > //depot/projects/soc2008/andenore_pkginstall/src/usr.sbin/pkg_install/lib/database.c#2 > edit > .. > //depot/projects/soc2008/andenore_pkginstall/src/usr.sbin/pkg_install/lib/global.c#2 > edit > .. > //depot/projects/soc2008/andenore_pkginstall/src/usr.sbin/pkg_install/lib/lib.h#3 > edit > .. > //depot/projects/soc2008/andenore_pkginstall/src/usr.sbin/pkg_install/lib/match.c#3 > edit Andre, Just one point: did you mean Port or Pkg? Remember that not all packages are ports, even though all ports can be packages. Otherwise, good work on the speedup and I'll be sure to help test out your repo-code if you like (IIRC pkg_install didn't have unit tests). Cheers, -Garrett
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?364299f40806091832g72ccee5ap462e698aea723f3b>